Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2517953002: Revert "Merge of source position information from kernel-sdk." (Closed)

Created:
4 years, 1 month ago by jensj
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Merge of source position information from kernel-sdk." The commit broke 2 tests: vm/cc/IsolateReload_TypeIdentityGeneric vm/cc/SourceReport_Coverage_AllFunctions_ForceCompile This reverts commit 6fd3a42edb4c7902a49811318de6bb6b18dbd829. BUG= Committed: https://github.com/dart-lang/sdk/commit/1056c562aab6465bfcf31a2fe486e523a7e07554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -296 lines) Patch
M runtime/vm/bootstrap.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap_nocore.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/kernel.h View 13 chunks +8 lines, -20 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 27 chunks +42 lines, -50 lines 0 comments Download
M runtime/vm/kernel_reader.h View 4 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 13 chunks +34 lines, -61 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 2 chunks +5 lines, -10 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 38 chunks +53 lines, -72 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +10 lines, -55 lines 0 comments Download
M runtime/vm/raw_object.h View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
tbr
4 years, 1 month ago (2016-11-21 10:05:44 UTC) #2
jensj
Committed patchset #1 (id:1) manually as 1056c562aab6465bfcf31a2fe486e523a7e07554 (presubmit successful).
4 years, 1 month ago (2016-11-21 10:16:36 UTC) #4
Kevin Millikin (Google)
4 years, 1 month ago (2016-11-21 10:39:24 UTC) #5
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698