Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 251793003: Make android bot configuration more consistent. (Closed)

Created:
6 years, 8 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
cmp, navabi1, navabi, zty, luqui, bulach
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make android bot configuration more consistent. On the chromium.perf waterfall, we have some devices that are not going offline (N4 + N5) and some that are (N7, N10, GN). Diffing the results of the provision_device step pointed out some configuration differences between the working and non-working devices. Most notably, wifi_on was set on all the devices that are going offline and not on the ones that are staying on. I hope making these settings deterministic will get these devices into better shape. BUG=366697 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M build/android/pylib/device_settings.py View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tonyg
6 years, 8 months ago (2014-04-25 17:13:00 UTC) #1
cmp
+luqui for review
6 years, 8 months ago (2014-04-25 19:07:25 UTC) #2
luqui
lgtm
6 years, 8 months ago (2014-04-25 19:10:26 UTC) #3
navabi
lgtm
6 years, 8 months ago (2014-04-25 19:27:22 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-25 19:54:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/251793003/1
6 years, 8 months ago (2014-04-25 22:08:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:19:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:19:46 UTC) #8
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-25 23:43:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/251793003/1
6 years, 8 months ago (2014-04-25 23:46:12 UTC) #10
tonyg
The CQ bit was unchecked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 03:27:05 UTC) #11
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 03:27:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/251793003/1
6 years, 8 months ago (2014-04-26 03:28:35 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-26 22:43:48 UTC) #14
Message was sent while issue was closed.
Change committed as 266394

Powered by Google App Engine
This is Rietveld 408576698