Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2517913002: [turbofan] Introduce LoadFunctionPrototype simplified operator. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce LoadFunctionPrototype simplified operator. Add a LoadFunctionPrototype simplified operator, similar to what Crankshaft has, that loads the prototype property of a constructor function. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/1737b2c74b50168e96ef1263def0eb43505fa80c Cr-Commit-Position: refs/heads/master@{#41127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M src/compiler/access-info.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/access-info.cc View 4 chunks +17 lines, -3 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-21 06:49:55 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the F.prototype lowering, so we get rid of these pesky LOAD_ICs. Please ...
4 years, 1 month ago (2016-11-21 07:15:32 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-21 07:23:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517913002/1
4 years, 1 month ago (2016-11-21 07:26:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 07:32:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1737b2c74b50168e96ef1263def0eb43505fa80c Cr-Commit-Position: refs/heads/master@{#41127}
4 years, 1 month ago (2016-11-21 07:32:43 UTC) #12
Michael Hablich
4 years, 1 month ago (2016-11-21 13:31:29 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2514363002/ by hablich@chromium.org.

The reason for reverting is: Blocks roll
https://codereview.chromium.org/2517963002/.

Powered by Google App Engine
This is Rietveld 408576698