Chromium Code Reviews
DescriptionRevert of Don't early out recursion into PaintLayerChildren when computing composited bounds. (patchset #6 id:100001 of https://codereview.chromium.org/2502833002/ )
Reason for revert:
Speculative revert for https://crbug.com/667144.
A checkfail in PaintController.cpp started happening reliably in between r433228
and r433235. This CL looks closely related.
BUG=667144
Original issue's description:
> Don't early out recursion into PaintLayerChildren when computing composited bounds.
>
> PaintLayer::boundingBoxForCompositing recursively computes the union of the
> bounds of a root PaintLayer and its non-comositing descendants. Previously, in PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
> into PaintLayer children if the PaintLayer was clipped. This is incorrect if there
> are any PaintLayer descendants that have different clipping ancestors than
> the current PaintLayer.
>
> Also fixed a bug that transform-related properties were not considered containing
> blocks for clipping of fixed-position children.
>
> BUG=618046
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0
> Cr-Commit-Position: refs/heads/master@{#433232}
TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=618046
Committed: https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77
Cr-Commit-Position: refs/heads/master@{#433468}
Patch Set 1 #
Messages
Total messages: 12 (7 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||