Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2517863002: Revert of Don't early out recursion into PaintLayerChildren when computing composited bounds. (Closed)

Created:
4 years, 1 month ago by Matt Giuca
Modified:
4 years, 1 month ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't early out recursion into PaintLayerChildren when computing composited bounds. (patchset #6 id:100001 of https://codereview.chromium.org/2502833002/ ) Reason for revert: Speculative revert for https://crbug.com/667144. A checkfail in PaintController.cpp started happening reliably in between r433228 and r433235. This CL looks closely related. BUG=667144 Original issue's description: > Don't early out recursion into PaintLayerChildren when computing composited bounds. > > PaintLayer::boundingBoxForCompositing recursively computes the union of the > bounds of a root PaintLayer and its non-comositing descendants. Previously, in PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing > into PaintLayer children if the PaintLayer was clipped. This is incorrect if there > are any PaintLayer descendants that have different clipping ancestors than > the current PaintLayer. > > Also fixed a bug that transform-related properties were not considered containing > blocks for clipping of fixed-position children. > > BUG=618046 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0 > Cr-Commit-Position: refs/heads/master@{#433232} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618046 Committed: https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77 Cr-Commit-Position: refs/heads/master@{#433468}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
Matt Giuca
Created Revert of Don't early out recursion into PaintLayerChildren when computing composited bounds.
4 years, 1 month ago (2016-11-21 00:46:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517863002/1
4 years, 1 month ago (2016-11-21 00:46:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517863002/1
4 years, 1 month ago (2016-11-21 00:47:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 02:19:38 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 02:21:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77
Cr-Commit-Position: refs/heads/master@{#433468}

Powered by Google App Engine
This is Rietveld 408576698