Http Bad: Put icon on the left of http warning message on Views

chrome/browser/ui/autofill/autofill_popup_layout_model.h

Index: chrome/browser/ui/autofill/autofill_popup_layout_model.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_layout_model.h b/chrome/browser/ui/autofill/autofill_popup_layout_model.h
index 57a4091a188317fbbb4eed14d966ad1c4ebc51cc..e9908dc8facfa603822ddb136140728782b9445e 100644
--- a/chrome/browser/ui/autofill/autofill_popup_layout_model.h
+++ b/chrome/browser/ui/autofill/autofill_popup_layout_model.h
@@ -38,9 +38,16 @@ class AutofillPopupLayoutModel {
   // in pixels.
   static const int kNamePadding = 15;
 
+  // The minimum amount of padding between the Autofill http warning message
+  // name and subtext, in pixels.
+  static const int kHttpWarningNamePadding = 8;
+
   // The amount of padding between icons in pixels.
   static const int kIconPadding = 5;
 
+  // The amount of padding between icons in pixels.
+  static const int kHttpWarningIconPadding = 8;

[Evan Stade, 2016/11/29 15:43:17]

I'm confused by this for two reasons - first because the comment is identical to
the above, and second because I didn't know there could be more than one icon
("between icons")

[lshang, 2016/11/30 05:43:36]

I advised the comments a bit to make it more clear. Are you OK with the new
version?

+
   // The amount of padding at the end of the popup in pixels.
   static const int kEndPadding = 8;
 
@@ -68,7 +75,7 @@ class AutofillPopupLayoutModel {
   // The same font can vary based on the type of data it is showing at the row
   // |index|.
   const gfx::FontList& GetValueFontListForRow(size_t index) const;
-  const gfx::FontList& GetLabelFontList() const;
+  const gfx::FontList& GetLabelFontListForRow(size_t index) const;
 
   // Returns the value font color of the row item according to its |index|.
   SkColor GetValueFontColorForRow(size_t index) const;