[cleanup] Refactor builtins-number.cc

[cleanup] Refactor builtins-number.cc

Introducing a TF_BUILTIN macro that wraps CodeStubAssembler usage
into a convenient interface (using a subclass under the hood).

Committed: https://crrev.com/cbf59c4c704e83a43b52c5ba6825df576fdaece8
Cr-Commit-Position: refs/heads/master@{#41236}

[Jakob Kummerow, 2016-11-22 15:56:12]

Patchset #1 (id:1) has been deleted

[Jakob Kummerow, 2016-11-22 15:58:58]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2016-11-22 15:58:58]

Here's the refactoring we discussed a couple of days ago. Please take an early
look. If you like the approach, I'll continue with the rest of the file. (And
then other files can follow suit later.)

[Igor Sheludko, 2016-11-22 18:25:20]

Awesome! Go ahead!

https://codereview.chromium.org/2517833005/diff/20001/src/builtins/builtins-u...
File src/builtins/builtins-utils.h (right):

https://codereview.chromium.org/2517833005/diff/20001/src/builtins/builtins-u...
src/builtins/builtins-utils.h:115: // through the (inherited)
CodeAssembler::Parameter() function.
I'm sorry, I don't follow.

[Igor Sheludko, 2016-11-23 14:36:19]

Awesome! lgtm!

[Jakob Kummerow, 2016-11-23 14:37:22]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-11-23 14:37:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 14:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 14:39:39]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16743)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16703)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/13084)

[Jakob Kummerow, 2016-11-24 00:10:13]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-11-24 00:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 00:41:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479946213615590,
"parent_rev": "eeffe3b508a597da8438331b3b7aca1b90c925de", "commit_rev":
"cfa83e4513df1a0c05bdafc9669934550c22e909"}

[commit-bot: I haz the power, 2016-11-24 00:41:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-24 00:42:02]

Description was changed from

==========
[cleanup] Refactor builtins-number.cc

Introducing a TF_BUILTIN macro that wraps CodeStubAssembler usage
into a convenient interface (using a subclass under the hood).
==========

to

==========
[cleanup] Refactor builtins-number.cc

Introducing a TF_BUILTIN macro that wraps CodeStubAssembler usage
into a convenient interface (using a subclass under the hood).

Committed: https://crrev.com/cbf59c4c704e83a43b52c5ba6825df576fdaece8
Cr-Commit-Position: refs/heads/master@{#41236}
==========

[commit-bot: I haz the power, 2016-11-24 00:42:03]

Patchset 2 (id:??) landed as
https://crrev.com/cbf59c4c704e83a43b52c5ba6825df576fdaece8
Cr-Commit-Position: refs/heads/master@{#41236}

[Michael Hablich, 2016-11-24 08:57:11]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2529873002/ by hablich@chromium.org.

The reason for reverting is: Secondary dependency to revert
https://codereview.chromium.org/2522393002/.