Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/exo/shell_surface_unittest.cc

Issue 2517833003: Allow to create ARC++ windows minimized on startup. (Closed)
Patch Set: Cleaned up the test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/exo/shell_surface.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/shell_surface_unittest.cc
diff --git a/components/exo/shell_surface_unittest.cc b/components/exo/shell_surface_unittest.cc
index 575dafc6d6f9d26540c2bc94ec67a8651d594d87..8675fa25ead70bff01f2e7d8ac33f56c793186c2 100644
--- a/components/exo/shell_surface_unittest.cc
+++ b/components/exo/shell_surface_unittest.cc
@@ -126,6 +126,11 @@ TEST_F(ShellSurfaceTest, Minimize) {
std::unique_ptr<Surface> surface(new Surface);
std::unique_ptr<ShellSurface> shell_surface(new ShellSurface(surface.get()));
+ // Minimizing can be performed before the surface is committed.
+ shell_surface->Minimize();
+ EXPECT_TRUE(shell_surface->GetWidget()->IsMinimized());
+
+ // Confirm that attaching and commiting doesn't reset the state.
surface->Attach(buffer.get());
surface->Commit();
reveman 2016/11/22 09:29:11 Would be nice to check that shell surface is still
mtomasz 2016/11/24 00:51:04 Acknowledged.
shell_surface->Minimize();
reveman 2016/11/22 09:29:11 Not sure it makes sense to test calling this now t
mtomasz 2016/11/24 00:51:04 Oops, minimizing here completely doesn't make sens
« no previous file with comments | « components/exo/shell_surface.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698