Fix #66.

Fix #66.

This fixes an issue where, when multiple entities have overlaping field names, the indexEntries function will happily generate index rows for indicies where the Kind doesn't match (oops).

R=dnj@chromium.org, vadimsh@chromium.org

Committed: https://github.com/luci/gae/commit/3d3367c3e63be9d05b0df0a8c728575f785b21b0

[iannucci, 2016-11-20 08:40:24]

Description was changed from

==========
Fix #66.

This fixes an issue where when AutoIndexing was turned on and it was scanning
through all entities, it wouldn't correctly filter entities by Kind. Thus
entities could end up sneaking into the wrong indicies when they shared fields.

R=dnj@chromium.org, vadimsh@chromium.org
==========

to

==========
Fix #66.

This fixes an issue where, when multiple entities have overlaping field names,
the indexEntries function will happily generate index rows for indicies where
the Kind doesn't match (oops).

R=dnj@chromium.org, vadimsh@chromium.org
==========

[dnj, 2016-11-20 16:44:26]

lgtm, few comments

https://codereview.chromium.org/2517833002/diff/1/impl/memory/datastore_test.go
File impl/memory/datastore_test.go (right):

https://codereview.chromium.org/2517833002/diff/1/impl/memory/datastore_test....
impl/memory/datastore_test.go:737: func TestAncestorChildFieldQuery(t
*testing.T) {
Can this test be folded up into one of the "datastore_intex_*test" test cases?
Feels weird having it sit top-level.

https://codereview.chromium.org/2517833002/diff/1/impl/memory/datastore_test....
impl/memory/datastore_test.go:751: // If you comment out the .Order part below,
the test succeeds
This comment can be removed.

[iannucci, 2016-11-20 18:38:01]

On 2016/11/20 16:44:26, dnj wrote:
> lgtm, few comments
> 
>
https://codereview.chromium.org/2517833002/diff/1/impl/memory/datastore_test.go
> File impl/memory/datastore_test.go (right):
> 
>
https://codereview.chromium.org/2517833002/diff/1/impl/memory/datastore_test....
> impl/memory/datastore_test.go:737: func TestAncestorChildFieldQuery(t
> *testing.T) {
> Can this test be folded up into one of the "datastore_intex_*test" test cases?
> Feels weird having it sit top-level.

Yep, good point. Done.

> 
>
https://codereview.chromium.org/2517833002/diff/1/impl/memory/datastore_test....
> impl/memory/datastore_test.go:751: // If you comment out the .Order part
below,
> the test succeeds
> This comment can be removed.

[iannucci, 2016-11-20 18:39:07]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-11-20 18:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2517833002/#ps20001
(title: "Move test")

[commit-bot: I haz the power, 2016-11-20 18:39:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 18:43:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479667147091810,
"parent_rev": ["c0be5453dd28277f0f25addf540c7e9a64dc98b9", null], "commit_rev":
["3d3367c3e63be9d05b0df0a8c728575f785b21b0", null]}

[commit-bot: I haz the power, 2016-11-20 18:43:29]

Description was changed from

==========
Fix #66.

This fixes an issue where, when multiple entities have overlaping field names,
the indexEntries function will happily generate index rows for indicies where
the Kind doesn't match (oops).

R=dnj@chromium.org, vadimsh@chromium.org
==========

to

==========
Fix #66.

This fixes an issue where, when multiple entities have overlaping field names,
the indexEntries function will happily generate index rows for indicies where
the Kind doesn't match (oops).

R=dnj@chromium.org, vadimsh@chromium.org

Committed:
https://github.com/luci/gae/commit/3d3367c3e63be9d05b0df0a8c728575f785b21b0
==========

[commit-bot: I haz the power, 2016-11-20 18:43:30]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/3d3367c3e63be9d05b0df0a8c728575f785b21b0