Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2517823002: [builtins] add CodeStubAssembler::IsDebugActive() helper (Closed)

Created:
4 years, 1 month ago by caitp
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] add CodeStubAssembler::IsDebugActive() helper Utility used by Promise builtins implemented in TFJ/TFS BUG=v8:5046 R=bmeurer@chromium.org, gsathya@chromium.org, yangguo@chromium.org, adamk@chromium.org Committed: https://crrev.com/d59c2cf1b40b4626605632a4e2e055531776c6a4 Cr-Commit-Position: refs/heads/master@{#41123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
caitp
Implemented after offline discussion with Sathya, hopefully this helps with the Promise work.
4 years, 1 month ago (2016-11-20 05:02:29 UTC) #3
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-20 17:34:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517823002/1
4 years, 1 month ago (2016-11-20 17:55:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-20 17:56:58 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 17:57:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d59c2cf1b40b4626605632a4e2e055531776c6a4
Cr-Commit-Position: refs/heads/master@{#41123}

Powered by Google App Engine
This is Rietveld 408576698