[MD settings] settings toggle control browser test addtion

[MD settings] settings toggle control browser test addtion

This CL cleans up the test setup and adds a test for the toggle control
in settings.

BUG=None

Committed: https://crrev.com/cd6c5a8e9e91ce4823ec377072f7b52816487152
Cr-Commit-Position: refs/heads/master@{#436094}

[dschuyler, 2016-11-19 02:55:19]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-11-19 02:55:49]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2016-11-19 02:55:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 04:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 04:33:55]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-11-30 20:14:39]

LGTM with question.

https://codereview.chromium.org/2517753002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/settings_toggle_button_tests.js (right):

https://codereview.chromium.org/2517753002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:21: * @type
{SettingsCheckbox}
This type annotation seems wrong. Should it be chrome.settingsPrivate.PrefObject
?

[dschuyler, 2016-12-01 19:33:56]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-12-01 19:34:25]

TY

https://codereview.chromium.org/2517753002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/settings_toggle_button_tests.js (right):

https://codereview.chromium.org/2517753002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:21: * @type
{SettingsCheckbox}
On 2016/11/30 20:14:39, dpapad wrote:
> This type annotation seems wrong. Should it be
chrome.settingsPrivate.PrefObject
> ?

Done.

[commit-bot: I haz the power, 2016-12-01 19:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 20:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 20:39:00]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-12-02 21:21:26]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-12-02 21:21:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2517753002/#ps20001
(title: "type change")

[commit-bot: I haz the power, 2016-12-02 21:22:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:20:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480713686132070,
"parent_rev": "cb7e5e3c88e24155bf0e65aed75d7f1b6c60fc5a", "commit_rev":
"7ba1491ab6419c05cd8de3b7ac9022b40c4295e3"}

[commit-bot: I haz the power, 2016-12-03 00:20:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 00:23:24]

Description was changed from

==========
[MD settings] settings toggle control browser test addtion

This CL cleans up the test setup and adds a test for the toggle control
in settings.

BUG=None
==========

to

==========
[MD settings] settings toggle control browser test addtion

This CL cleans up the test setup and adds a test for the toggle control
in settings.

BUG=None

Committed: https://crrev.com/cd6c5a8e9e91ce4823ec377072f7b52816487152
Cr-Commit-Position: refs/heads/master@{#436094}
==========

[commit-bot: I haz the power, 2016-12-03 00:23:25]

Patchset 2 (id:??) landed as
https://crrev.com/cd6c5a8e9e91ce4823ec377072f7b52816487152
Cr-Commit-Position: refs/heads/master@{#436094}