Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2517743002: Import wpt@5a1f188e0536ad023936cc62f9a00617299dc192 (Closed)

Created:
4 years, 1 month ago by jsbell
Modified:
4 years, 1 month ago
Reviewers:
tkent, qyearsley
CC:
asanka, blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, cmumford, jkarlin, ortuno+watch_chromium.org, scheib+watch_chromium.org, shimazu, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import wpt@5a1f188e0536ad023936cc62f9a00617299dc192 Using update-w3c-deps in Chromium 2040bff2a904885249b1d58f3950b80ae45ebcbd. Imports the service-workers/cache-storage as well as recent upstream changes. BUG=666991, 666993, 432746, 667376 Committed: https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf Cr-Commit-Position: refs/heads/master@{#433651}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add TestExpectations entry for crbug.com/667376 #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3101 lines, -644 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/DOM-parsing/todo/internalSubset.html View 1 chunk +0 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/historical.html View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces.html View 2 chunks +17 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces.idl View 1 chunk +166 lines, -112 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces-expected.txt View 7 chunks +55 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces.worker.js View 1 chunk +44 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json View 7 chunks +218 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/console/console-is-a-namespace.any.js View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/dpub-aam/README.md View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/dpub-aria/README.md View 1 chunk +0 lines, -64 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/resetting-a-form/reset-event.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/idle-callbacks/basic.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/idle-callbacks/callback-idle-periods.html View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/idle-callbacks/callback-timeout-with-raf.html View 1 chunk +69 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/mediacapture-record/BlobEvent-constructor.html View 1 chunk +0 lines, -38 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/common.https.html View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/blank.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/common-worker.js View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/credentials-iframe.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/credentials-worker.js View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/fetch-status.py View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/iframe.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/simple.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/test-helpers.js View 1 chunk +237 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/resources/testharness-helpers.js View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-add.js View 1 chunk +238 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-delete.js View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-match.js View 1 chunk +193 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-matchAll.js View 1 chunk +154 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-put.js View 1 chunk +287 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage.js View 1 chunk +197 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage-keys.js View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js View 1 chunk +124 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-delete.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-match.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-put.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage-match.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage.https.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/credentials.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/credentials-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-add.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-add.https-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-delete.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-match.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-match.https-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-matchAll.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-matchAll.https-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-put.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-put.https-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage-keys.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage-match.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-storage.https-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/sandboxed-iframes.https.html View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-add.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-add.https-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-delete.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-match.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-matchAll.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-put.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage-keys.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage-match.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage.https.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-storage.https-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-009.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-009-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/wai-aria/README.md View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
jsbell
qyearsley@, tkent@ - please take a look? Filed https://crbug.com/666991 for the cache-storage flakes that'll need ...
4 years, 1 month ago (2016-11-19 00:54:39 UTC) #4
jsbell
A few random notes on new expectations... https://codereview.chromium.org/2517743002/diff/1/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt File third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt (right): https://codereview.chromium.org/2517743002/diff/1/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt#newcode18 third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:18: FAIL Cache.addAll ...
4 years, 1 month ago (2016-11-19 01:02:29 UTC) #6
tkent
lgtm
4 years, 1 month ago (2016-11-21 01:04:11 UTC) #9
qyearsley
lgtm too although I didn't look very closely
4 years, 1 month ago (2016-11-21 16:48:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517743002/20001
4 years, 1 month ago (2016-11-21 18:11:24 UTC) #14
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-21 19:09:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517743002/40001
4 years, 1 month ago (2016-11-21 20:03:53 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 21:12:07 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:16:25 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/80cc8049a86123976cc7255f2bcd689322f596bf
Cr-Commit-Position: refs/heads/master@{#433651}

Powered by Google App Engine
This is Rietveld 408576698