Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2517733002: Throw IPC errors on invalid Mojo BlobChannel messages. (Closed)

Created:
4 years, 1 month ago by Kevin M
Modified:
4 years, 1 month ago
Reviewers:
Menglin
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, yzshen+watch_chromium.org, abarth-chromium, nyquist+watch-blimp_chromium.org, Aaron Boodman, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, Wez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw IPC errors on invalid Mojo BlobChannel messages. This code instructs the browser to kill a renderer process if it receives semantically invalid/bad data over the Mojo pipe. BUG=629096 R=mlliu@chromium.org CC=wez@chromium.org Committed: https://crrev.com/2de9572364f3e2b29aad7837ec0d36651464a1f7 Cr-Commit-Position: refs/heads/master@{#433371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M blimp/engine/mojo/blob_channel_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kevin M
4 years, 1 month ago (2016-11-18 23:57:53 UTC) #1
Menglin
On 2016/11/18 23:57:53, Kevin M wrote: lgtm
4 years, 1 month ago (2016-11-19 00:15:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517733002/1
4 years, 1 month ago (2016-11-19 01:15:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 01:35:58 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:38:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2de9572364f3e2b29aad7837ec0d36651464a1f7
Cr-Commit-Position: refs/heads/master@{#433371}

Powered by Google App Engine
This is Rietveld 408576698