Issue 251773003: [Android] Add more tests for Java Bridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251773003: [Android] Add more tests for Java Bridge (Closed)

Created:
6 years, 8 months ago by mnaganov (inactive)

Modified:
6 years, 7 months ago

Reviewers:
benm (inactive)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Android] Add more tests for Java Bridge Verify how the existing implementation deals with Date, Function and RegExp JS objects. This is to make sure that we configure V8ValueConverter appropriately in the Gin-based implementation. BUG=355644 R=benm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266526

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

mnaganov (inactive)

Ben, PTAL! A trivial change just to document existing behaviour of Java bridge.

6 years, 8 months ago (2014-04-25 14:55:07 UTC) #1

mnaganov (inactive)

The CQ bit was checked by mnaganov@chromium.org

6 years, 8 months ago (2014-04-25 15:09:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/251773003/1

6 years, 8 months ago (2014-04-25 22:17:11 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-25 23:57:39 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on win_chromium_rel

6 years, 8 months ago (2014-04-25 23:57:40 UTC) #6

mnaganov (inactive)

6 years, 7 months ago (2014-04-28 12:33:27 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r266526 (presubmit successful).