Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2517693002: Add null check in createTransparentImage (Closed)

Created:
4 years, 1 month ago by Justin Novosad
Modified:
4 years ago
Reviewers:
junov1, Stephen White
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check in createTransparentImage BUG=666630 Committed: https://crrev.com/edbaf210e408c0c06c5f1dba250d1a5e33bb3c6e Cr-Commit-Position: refs/heads/master@{#434711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Justin Novosad
4 years, 1 month ago (2016-11-18 22:09:04 UTC) #2
Stephen White
LGTM
4 years, 1 month ago (2016-11-18 22:09:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517693002/1
4 years, 1 month ago (2016-11-18 22:12:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/318383)
4 years, 1 month ago (2016-11-19 02:25:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517693002/1
4 years, 1 month ago (2016-11-21 01:37:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276599)
4 years, 1 month ago (2016-11-21 05:39:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517693002/1
4 years ago (2016-11-28 15:54:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 20:30:04 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-28 20:32:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edbaf210e408c0c06c5f1dba250d1a5e33bb3c6e
Cr-Commit-Position: refs/heads/master@{#434711}

Powered by Google App Engine
This is Rietveld 408576698