Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2517623002: [ObjC ARC] Converts ios/chrome/browser:about_flags to ARC.Automatically generated ARCMigrate comm… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser:about_flags to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/0640337e8f5b67e940390fcb6b4efc846afdc9a7 Cr-Commit-Position: refs/heads/master@{#433566}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comiole guard fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 11:56:11 UTC) #6
sdefresne
https://codereview.chromium.org/2517623002/diff/1/ios/chrome/browser/about_flags.mm File ios/chrome/browser/about_flags.mm (right): https://codereview.chromium.org/2517623002/diff/1/ios/chrome/browser/about_flags.mm#newcode40 ios/chrome/browser/about_flags.mm:40: #if !defined(__has_feature) || !__has_feature(objc_arc) This is incorrect, this must ...
4 years, 1 month ago (2016-11-21 12:04:18 UTC) #7
stkhapugin
Thanks, ptal! https://codereview.chromium.org/2517623002/diff/1/ios/chrome/browser/about_flags.mm File ios/chrome/browser/about_flags.mm (right): https://codereview.chromium.org/2517623002/diff/1/ios/chrome/browser/about_flags.mm#newcode40 ios/chrome/browser/about_flags.mm:40: #if !defined(__has_feature) || !__has_feature(objc_arc) On 2016/11/21 12:04:18, ...
4 years, 1 month ago (2016-11-21 15:34:55 UTC) #8
sdefresne
lgtm
4 years, 1 month ago (2016-11-21 15:36:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517623002/20001
4 years, 1 month ago (2016-11-21 15:43:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 16:49:45 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:53:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0640337e8f5b67e940390fcb6b4efc846afdc9a7
Cr-Commit-Position: refs/heads/master@{#433566}

Powered by Google App Engine
This is Rietveld 408576698