Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2517583002: [ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC.Automatically generated ARCM… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/5735d3c3b80eea8ba1e05f67fff0708cb672423d Cr-Commit-Position: refs/heads/master@{#433252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/sync/sessions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
ptal
4 years, 1 month ago (2016-11-18 16:27:30 UTC) #6
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-18 17:18:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517583002/1
4 years, 1 month ago (2016-11-18 18:36:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:44:50 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:46:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5735d3c3b80eea8ba1e05f67fff0708cb672423d
Cr-Commit-Position: refs/heads/master@{#433252}

Powered by Google App Engine
This is Rietveld 408576698