Compute and flush only affected transitive signatures in FileState.

Compute and flush only affected transitive signatures in FileState.

When we keep these signatures, recovery time for change/undo improves
for analyzer + analysis_server from 700 ms to 360 ms.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0e4e9ed8aa22b4ab668a066d92f51c0102ec7466

[Paul Berry, 2016-11-21 13:58:00]

lgtm assuming fix below is applied.

https://codereview.chromium.org/2517513005/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2517513005/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:190: transitiveFiles
It *probably* won't matter, but for safety, we should do
`signature.addUint32(transitiveFiles.length);` before this line.

(The idea is that in order to avoid accidentally producing signature collisions,
it should in theory be possible to deserialize the original data from the
signature bytes.  Adding the length means that if we were trying to deserialize
the data, we would know when to stop decoding transitive file signatures and
start decoding the URI).

[Brian Wilkerson, 2016-11-21 15:57:05]

lgtm

[scheglov, 2016-11-21 16:51:53]

https://codereview.chromium.org/2517513005/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2517513005/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:190: transitiveFiles
On 2016/11/21 13:58:00, Paul Berry wrote:
> It *probably* won't matter, but for safety, we should do
> `signature.addUint32(transitiveFiles.length);` before this line.
> 
> (The idea is that in order to avoid accidentally producing signature
collisions,
> it should in theory be possible to deserialize the original data from the
> signature bytes.  Adding the length means that if we were trying to
deserialize
> the data, we would know when to stop decoding transitive file signatures and
> start decoding the URI).

Done.

[scheglov, 2016-11-21 16:53:22]

Description was changed from

==========
Compute and flush only affected transitive signatures in FileState.

When we keep these signatures, recovery time for change/undo improves
for analyzer + analysis_server from 700 ms to 360 ms.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Compute and flush only affected transitive signatures in FileState.

When we keep these signatures, recovery time for change/undo improves
for analyzer + analysis_server from 700 ms to 360 ms.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0e4e9ed8aa22b4ab668a066d92f51c0102ec7466
==========

[scheglov, 2016-11-21 16:53:23]

Committed patchset #1 (id:1) manually as
0e4e9ed8aa22b4ab668a066d92f51c0102ec7466 (presubmit successful).