Add unit test for CXFA_FileRead.

Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.

Fix some issues with null dictionaries as provided by the
CPDF_Stream default ctor along the way.

Committed: https://pdfium.googlesource.com/pdfium/+/430ab8363e77c48b2c2435af4d289f85e2be1b96

[Tom Sepez, 2016-11-18 21:53:41]

Description was changed from

==========
Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.
==========

to

==========
Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.

Fix some issues with null dictionaries as provided by the
default ctor along the way.
==========

[Tom Sepez, 2016-11-18 21:53:42]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-11-18 21:53:49]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 21:53:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-18 21:53:59]

Dan, ready for review.

[Tom Sepez, 2016-11-18 22:01:16]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2016-11-18 22:01:29]

Or npm, if you get to it first.

[Tom Sepez, 2016-11-18 22:01:53]

Description was changed from

==========
Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.

Fix some issues with null dictionaries as provided by the
default ctor along the way.
==========

to

==========
Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.

Fix some issues with null dictionaries as provided by the
CPDF_Stream default ctor along the way.
==========

[commit-bot: I haz the power, 2016-11-18 22:08:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:08:45]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-18 22:37:28]

lgtm
What happens when we try to ReadBlock something longer than the stream length?

[Tom Sepez, 2016-11-18 22:47:56]

On 2016/11/18 22:37:28, npm wrote:
> lgtm
> What happens when we try to ReadBlock something longer than the stream length?

Short return of available data.

[Tom Sepez, 2016-11-18 22:48:01]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:48:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:48:23]

Description was changed from

==========
Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.

Fix some issues with null dictionaries as provided by the
CPDF_Stream default ctor along the way.
==========

to

==========
Add unit test for CXFA_FileRead.

The FileRead's return convention is being modified at
https://codereview.chromium.org/2430743003/, so first provide
a test of the old behaviour.

Fix some issues with null dictionaries as provided by the
CPDF_Stream default ctor along the way.

Committed:
https://pdfium.googlesource.com/pdfium/+/430ab8363e77c48b2c2435af4d289f85e2be...
==========

[commit-bot: I haz the power, 2016-11-18 22:48:24]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/430ab8363e77c48b2c2435af4d289f85e2be...