Make printing PDF work from inside PDF extension.

Make printing PDF work from PDF extension.

When clicking PDF extension's print button, the window suddenly disappears.
This happens because PrintViewManager's |print_preview_rfh_| is never set
to the main frame of the extension.

This CL makes sure this happens when the renderer sends the corresponding
RequestPrintPreview command.

BUG=666432

[EhsanK, 2016-11-18 04:29:59]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 04:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2016-11-18 04:30:30]

Description was changed from

==========
Make printing PDF work from PDF extension.

When clicking PDF extension's print button, the window suddenly disappears.
This happens because PrintViewManager's |print_preview_rfh_| is never set
to the main frame of the extension.

This CL makes sure this happens when the renderer sends the corresponding
RequestPrintPreview command.

BUG=666432
==========

to

==========
Make printing PDF work from PDF extension.

When clicking PDF extension's print button, the window suddenly disappears.
This happens because PrintViewManager's |print_preview_rfh_| is never set
to the main frame of the extension.

This CL makes sure this happens when the renderer sends the corresponding
RequestPrintPreview command.

BUG=666432
==========

[EhsanK, 2016-11-18 04:34:34]

ekaramad@chromium.org changed reviewers:
+ alexmos@chromium.org, thestig@chromium.org

[EhsanK, 2016-11-18 04:34:35]

I am not sure if this is wrong, but it will fix the issue up to the SkCanvas
crash.

The issue, as I understand is that The preview RFH is not set properly in
response to PrintHostMsg_RequestPrintPreview.

That being said, what I did here might be wrong (I have a feeling it is). I do
not know this part of the code base very well. But I hope at least this will
expedite the process of finding the actual fix.

PTAL.

[commit-bot: I haz the power, 2016-11-18 07:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:13:11]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-21 07:07:36]

On 2016/11/18 04:34:35, EhsanK wrote:
> That being said, what I did here might be wrong (I have a feeling it is). I do
> not know this part of the code base very well. But I hope at least this will
> expedite the process of finding the actual fix.

It actually works well for PDFs in my testing. It's "wrong" in that it only
handles PDFs and not other content like Flash. I don't know if there are any
other plugins that we can print that we are forgetting about.

[Lei Zhang, 2016-11-21 09:49:46]

On 2016/11/21 07:07:36, Lei Zhang (Mostly OOO) wrote:
> On 2016/11/18 04:34:35, EhsanK wrote:
> > That being said, what I did here might be wrong (I have a feeling it is). I
do
> > not know this part of the code base very well. But I hope at least this will
> > expedite the process of finding the actual fix.
> 
> It actually works well for PDFs in my testing. It's "wrong" in that it only
> handles PDFs and not other content like Flash. I don't know if there are any
> other plugins that we can print that we are forgetting about.

Let me know how this looks: https://codereview.chromium.org/2518993002

[EhsanK, 2016-11-21 16:33:11]

On 2016/11/21 09:49:46, Lei Zhang (Mostly OOO) wrote:
> On 2016/11/21 07:07:36, Lei Zhang (Mostly OOO) wrote:
> > On 2016/11/18 04:34:35, EhsanK wrote:
> > > That being said, what I did here might be wrong (I have a feeling it is).
I
> do
> > > not know this part of the code base very well. But I hope at least this
will
> > > expedite the process of finding the actual fix.
> > 
> > It actually works well for PDFs in my testing. It's "wrong" in that it only
> > handles PDFs and not other content like Flash. I don't know if there are any
> > other plugins that we can print that we are forgetting about.
> 
> Let me know how this looks: https://codereview.chromium.org/2518993002

Closing this CL in favor of thestig@'s CL above.