Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: runtime/observatory/tests/service/get_allocation_samples_test.dart

Issue 2517473002: Fix tsan failure (Closed)
Patch Set: Address code review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/platform/assert.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'dart:developer'; 6 import 'dart:developer';
7 import 'package:observatory/models.dart' as M; 7 import 'package:observatory/models.dart' as M;
8 import 'package:observatory/service_io.dart'; 8 import 'package:observatory/service_io.dart';
9 import 'package:observatory/cpu_profile.dart'; 9 import 'package:observatory/cpu_profile.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 expect(profileResponse['type'], equals('_CpuProfile')); 60 expect(profileResponse['type'], equals('_CpuProfile'));
61 await fooClass.setTraceAllocations(false); 61 await fooClass.setTraceAllocations(false);
62 await fooClass.reload(); 62 await fooClass.reload();
63 expect(fooClass.traceAllocations, isFalse); 63 expect(fooClass.traceAllocations, isFalse);
64 CpuProfile cpuProfile = new CpuProfile(); 64 CpuProfile cpuProfile = new CpuProfile();
65 await cpuProfile.load(isolate, profileResponse); 65 await cpuProfile.load(isolate, profileResponse);
66 cpuProfile.buildCodeCallerAndCallees(); 66 cpuProfile.buildCodeCallerAndCallees();
67 cpuProfile.buildFunctionCallerAndCallees(); 67 cpuProfile.buildFunctionCallerAndCallees();
68 var tree = cpuProfile.loadCodeTree(M.ProfileTreeDirection.exclusive); 68 var tree = cpuProfile.loadCodeTree(M.ProfileTreeDirection.exclusive);
69 var node = tree.root; 69 var node = tree.root;
70 var expected = 70 var expected = ['Root', 'DRT_AllocateObject', '[Stub] Allocate Foo',
71 ['Root', 'DRT_AllocateObject', 'test', 'test', '_Closure.call']; 71 'test', 'test', '_Closure.call'];
72 for (var i = 0; i < expected.length; i++) { 72 for (var i = 0; i < expected.length; i++) {
73 expect(node.profileCode.code.name, equals(expected[i])); 73 expect(node.profileCode.code.name, equals(expected[i]));
74 // Depth first traversal. 74 // Depth first traversal.
75 if (node.children.length == 0) { 75 if (node.children.length == 0) {
76 node = null; 76 node = null;
77 } else { 77 } else {
78 node = node.children[0]; 78 node = node.children[0];
79 } 79 }
80 expect(node, isNotNull); 80 expect(node, isNotNull);
81 } 81 }
82 }, 82 },
83 resumeIsolate, 83 resumeIsolate,
84 ]; 84 ];
85 85
86 main(args) async => runIsolateTests(args, tests, testeeConcurrent:test); 86 main(args) async => runIsolateTests(args, tests, testeeConcurrent:test);
OLDNEW
« no previous file with comments | « no previous file | runtime/platform/assert.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698