Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2517463004: [ObjC ARC] Converts ios/testing:ios_test_support to ARC.Automatically generated ARCMigrate commit… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/testing:ios_test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/1a6a279b85842250fd42dbccae2d7e0e695beebf Cr-Commit-Position: refs/heads/master@{#436287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/testing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/testing/wait_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL
4 years ago (2016-11-24 15:41:19 UTC) #6
sdefresne
lgtm
4 years ago (2016-11-24 15:44:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517463004/1
4 years ago (2016-12-05 13:31:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 14:33:19 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 14:35:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a6a279b85842250fd42dbccae2d7e0e695beebf
Cr-Commit-Position: refs/heads/master@{#436287}

Powered by Google App Engine
This is Rietveld 408576698