Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2517443002: Revert of Disallow posting tasks to SequencedWorkerPools by default. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
gab, brettw, fdoray
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disallow posting tasks to SequencedWorkerPools by default. (patchset #24 id:460001 of https://codereview.chromium.org/2445763002/ ) Reason for revert: Probable cause of test failures: "cronet_test_instrumentation_apk" on "Android Cronet Builder (dbg)" https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/3581 Original issue's description: > Disallow posting tasks to SequencedWorkerPools by default. > > We have observed crash reports in which SequencedWorkerPool workers > were active while redirection to TaskScheduler was enabled. This can > happen if a task is posted to a SequencedWorkerPool before redirection > to TaskScheduler is enabled. With this CL, DumpWithoutCrashing is > called if a task is posted to a SequencedWorkerPool too early. This > will help us find offending call sites. > > BUG=622400 > > Committed: https://crrev.com/4606ada249a240e115a08a7c66409e8fdd457ea1 > Cr-Commit-Position: refs/heads/master@{#432913} TBR=gab@chromium.org,brettw@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622400 Committed: https://crrev.com/8f211d4a78b61ab2b70995c4a0a5d6ae2e24d62e Cr-Commit-Position: refs/heads/master@{#432989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -169 lines) Patch
M base/test/launcher/test_launcher.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 2 chunks +17 lines, -23 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 26 chunks +90 lines, -57 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 4 chunks +7 lines, -23 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Evan Stade
Created Revert of Disallow posting tasks to SequencedWorkerPools by default.
4 years, 1 month ago (2016-11-17 22:12:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517443002/1
4 years, 1 month ago (2016-11-17 22:13:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 22:14:48 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f211d4a78b61ab2b70995c4a0a5d6ae2e24d62e
Cr-Commit-Position: refs/heads/master@{#432989}

Powered by Google App Engine
This is Rietveld 408576698