Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2517413002:
Remove an irrelevant comment in WallpaperManagerBase (Closed)
DescriptionRemove an irrelevant comment in WallpaperManagerBase
The comment is irrelevant as this function does nothing to do
with Bytes. ResizeCustomizedDefaultWallpaper() used to take
UserImage::Bytes but that parameter was removed in crrev.com/385364
BUG=593251
Committed: https://crrev.com/191042a3113a57ad07f89f0501a351bb5e01a1cd
Cr-Commit-Position: refs/heads/master@{#434914}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 25 (14 generated)
satorux@chromium.org changed reviewers: + bshe@chromium.org
The CQ bit was checked by satorux@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/22 04:56:09, satorux1 wrote: lgtm
The CQ bit was checked by satorux@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by satorux@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by satorux@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by satorux@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480398207740830, "parent_rev":
"d63451dc4611a87986fc6c227e61d52b1e4cd912", "commit_rev":
"615a0960a49bedfa4a3000610cf4bcd6c9903af0"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove an irrelevant comment in WallpaperManagerBase The comment is irrelevant as this function does nothing to do with Bytes. ResizeCustomizedDefaultWallpaper() used to take UserImage::Bytes but that parameter was removed in crrev.com/385364 BUG=593251 ========== to ========== Remove an irrelevant comment in WallpaperManagerBase The comment is irrelevant as this function does nothing to do with Bytes. ResizeCustomizedDefaultWallpaper() used to take UserImage::Bytes but that parameter was removed in crrev.com/385364 BUG=593251 Committed: https://crrev.com/191042a3113a57ad07f89f0501a351bb5e01a1cd Cr-Commit-Position: refs/heads/master@{#434914} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/191042a3113a57ad07f89f0501a351bb5e01a1cd Cr-Commit-Position: refs/heads/master@{#434914} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
