Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2517393002: [Extensions] Remove RequestSender::ScopedTabID (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove RequestSender::ScopedTabID Remove RequestSender::ScopedTabID. This was used to set the tab id, and then passed to the browser in the request params for the API call, but a) Was only set in a response to ExtensionMsg_DeliverMessage (?) and b) The tab id can (and should) be obtained from the ExtensionFrameHelper Ideally, we'll also remove the tab id from the request params entirely, but this is a decent start. It also helps remove a blocker for extension bindings. BUG=667583 BUG=653596 Committed: https://crrev.com/c97b791906cf18bb1d5232ba881287db9898cd84 Cr-Commit-Position: refs/heads/master@{#433948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -36 lines) Patch
M extensions/renderer/dispatcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/renderer/request_sender.h View 2 chunks +0 lines, -16 lines 0 comments Download
M extensions/renderer/request_sender.cc View 3 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Devlin
4 years, 1 month ago (2016-11-22 15:44:53 UTC) #8
lazyboy
lgtm
4 years, 1 month ago (2016-11-22 19:19:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517393002/1
4 years, 1 month ago (2016-11-22 19:42:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 19:51:01 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 19:52:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c97b791906cf18bb1d5232ba881287db9898cd84
Cr-Commit-Position: refs/heads/master@{#433948}

Powered by Google App Engine
This is Rietveld 408576698