components/offline_pages/background/BUILD.gn - Issue 2517383008: [Offline pages] Adding GetRequestsTask to RequestQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/BUILD.gn

Issue 2517383008: [Offline pages] Adding GetRequestsTask to RequestQueue (Closed)

Patch Set: Addressing CR feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/BUILD.gn

diff --git a/components/offline_pages/background/BUILD.gn b/components/offline_pages/background/BUILD.gn

index 67442cefdfe4a0012d331791984938351431783d..315ad48de831ca63906fc9244a170a80010b73c5 100644

--- a/components/offline_pages/background/BUILD.gn

+++ b/components/offline_pages/background/BUILD.gn

@@ -11,6 +11,8 @@ static_library("background_offliner") {

"change_requests_state_task.cc",

"change_requests_state_task.h",

"device_conditions.h",

+ "get_requests_task.cc",

+ "get_requests_task.h",

"mark_attempt_aborted_task.cc",

"mark_attempt_aborted_task.h",

"mark_attempt_completed_task.cc",

@@ -82,6 +84,7 @@ source_set("unit_tests") {

testonly = true

sources = [

"change_requests_state_task_unittest.cc",

+ "get_requests_task_unittest.cc",

"mark_attempt_aborted_task_unittest.cc",

"mark_attempt_completed_task_unittest.cc",

"mark_attempt_started_task_unittest.cc",

« no previous file with comments | « no previous file | components/offline_pages/background/get_requests_task.h » ('j') | no next file with comments »