[Offline pages] Adding GetRequestsTask to RequestQueue

components/offline_pages/background/get_requests_task_unittest.cc

Index: components/offline_pages/background/get_requests_task_unittest.cc
diff --git a/components/offline_pages/background/get_requests_task_unittest.cc b/components/offline_pages/background/get_requests_task_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8fa119fc76b101bf5cfcf1698c718692fec33c30
--- /dev/null
+++ b/components/offline_pages/background/get_requests_task_unittest.cc
@@ -0,0 +1,123 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/background/get_requests_task.h"
+
+#include <memory>
+
+#include "base/bind.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "components/offline_pages/background/request_queue_in_memory_store.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace offline_pages {
+namespace {
+const int64_t kRequestId1 = 42;
+const int64_t kRequestId2 = 44;
+const GURL kUrl1("http://example.com");
+const GURL kUrl2("http://otherexample.com");
+const ClientId kClientId1("download", "1234");
+const ClientId kClientId2("download", "5678");
+}  // namespace
+
+class GetRequestsTaskTest : public testing::Test {
+ public:
+  GetRequestsTaskTest();
+  ~GetRequestsTaskTest() override;
+
+  void PumpLoop();
+
+  void AddItemsToStore(RequestQueueStore* store);
+
+  void AddRequestDone(ItemActionStatus status);
+
+  void GetRequestsCallback(
+      bool success,
+      std::vector<std::unique_ptr<SavePageRequest>> requests);
+
+  bool callback_called() const { return callback_called_; }
+
+  bool last_call_successful() const { return success_; }
+
+  const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const {
+    return requests_;
+  }
+
+ private:
+  bool callback_called_;
+  bool success_;
+  std::vector<std::unique_ptr<SavePageRequest>> requests_;
+  scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+  base::ThreadTaskRunnerHandle task_runner_handle_;
+};
+
+GetRequestsTaskTest::GetRequestsTaskTest()
+    : callback_called_(false),
+      success_(false),
+      task_runner_(new base::TestSimpleTaskRunner),
+      task_runner_handle_(task_runner_) {}
+
+GetRequestsTaskTest::~GetRequestsTaskTest() {}
+
+void GetRequestsTaskTest::PumpLoop() {
+  task_runner_->RunUntilIdle();
+}
+
+void GetRequestsTaskTest::AddItemsToStore(RequestQueueStore* store) {
+  base::Time creation_time = base::Time::Now();
+  SavePageRequest request_1(kRequestId1, kUrl1, kClientId1, creation_time,
+                            true);
+  store->AddRequest(request_1, base::Bind(&GetRequestsTaskTest::AddRequestDone,
+                                          base::Unretained(this)));
+  creation_time = base::Time::Now();
+  SavePageRequest request_2(kRequestId2, kUrl2, kClientId2, creation_time,
+                            true);
+  store->AddRequest(request_2, base::Bind(&GetRequestsTaskTest::AddRequestDone,
+                                          base::Unretained(this)));
+  PumpLoop();
+}
+
+void GetRequestsTaskTest::AddRequestDone(ItemActionStatus status) {
+  ASSERT_EQ(ItemActionStatus::SUCCESS, status);
+}
+
+void GetRequestsTaskTest::GetRequestsCallback(
+    bool success,
+    std::vector<std::unique_ptr<SavePageRequest>> requests) {
+  callback_called_ = true;
+  success_ = success;
+  requests_ = std::move(requests);
+}
+
+TEST_F(GetRequestsTaskTest, GetFromEmptyStore) {
+  RequestQueueInMemoryStore store;
+  GetRequestsTask task(&store,
+                       base::Bind(&GetRequestsTaskTest::GetRequestsCallback,
+                                  base::Unretained(this)));
+  task.Run();
+  PumpLoop();
+  EXPECT_TRUE(callback_called());
+  EXPECT_TRUE(last_call_successful());
+  EXPECT_TRUE(last_requests().empty());
+}
+
+TEST_F(GetRequestsTaskTest, GetMultipleRequests) {
+  RequestQueueInMemoryStore store;
+  AddItemsToStore(&store);
+
+  GetRequestsTask task(&store,
+                       base::Bind(&GetRequestsTaskTest::GetRequestsCallback,
+                                  base::Unretained(this)));
+  task.Run();
+  PumpLoop();
+  EXPECT_TRUE(callback_called());
+  EXPECT_TRUE(last_call_successful());
+  ASSERT_EQ(2UL, last_requests().size());
+
+  EXPECT_EQ(kRequestId1, last_requests().at(0)->request_id());

[dougarnett, 2016/11/28 18:48:41]

Is this a more strict check than necessary? That is, the store does not define
an ordering but these checks depend on the implemenation's ordering.

[fgorski, 2016/11/28 19:14:56]

Done. And yes, I was piggybacking on implementation details of in-memory store.

+  EXPECT_EQ(kRequestId2, last_requests().at(1)->request_id());
+}
+
+}  // namespace offline_pages