Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2239)

Unified Diff: appengine/findit/crash/results.py

Issue 2517383005: Implementing loglinear classification (without training), for CL classification (Closed)
Patch Set: breaking apart normalized and unnormalized models Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/results.py
diff --git a/appengine/findit/crash/results.py b/appengine/findit/crash/results.py
index 6504e679c9489a0db3765131cd2ceff3664431a4..07a55512fa78092ecea85798d58d44f8cce3539a 100644
--- a/appengine/findit/crash/results.py
+++ b/appengine/findit/crash/results.py
@@ -4,6 +4,9 @@
from collections import namedtuple
+
+# TODO(wrengr): we should change things to use integers with None as
+# \"infinity\", rather than using floats.
# TODO(http://crbug.com/644476): this class needs a better name.
class AnalysisInfo(namedtuple('AnalysisInfo',
['min_distance', 'min_distance_frame'])):
@@ -144,7 +147,7 @@ def _DistanceBetweenLineRanges((start1, end1), (start2, end2)):
class MatchResults(dict):
- """A dict indexing MatchResult with its revision."""
+ """A map from revisions to the MatchResult object for that revision."""
def __init__(self, ignore_cls=None):
super(MatchResults, self).__init__()
@@ -152,7 +155,7 @@ class MatchResults(dict):
def GenerateMatchResults(self, file_path, dep_path,
stack_infos, changelogs, blame):
- """Generates match results.
+ """Compute match results from a list of CLs, and store them.
Match results are generated based on newly found file path, its stack_infos,
and all the changelogs that touched this file in the dep in regression

Powered by Google App Engine
This is Rietveld 408576698