[scheduler] Bunch of improvements for blink scheduler tracing

[scheduler] Bunch of improvements for blink scheduler tracing

- Renamed id to task_queue_id due to tracing infrastructure not
  supporting "id" as a field name.
- Added renderer scheduler policy to trace dump.
- Added queue_details to task queue throttler trace dump.

R=skyostil@chromium.org
CC=alexclarke@chromium.org

Committed: https://crrev.com/c3f2e3d02a25ff5094268fe11c6d7357513a0609
Cr-Commit-Position: refs/heads/master@{#434096}

[altimin, 2016-11-22 16:05:03]

PTAL

[altimin, 2016-11-22 16:05:24]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 16:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 17:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 17:26:17]

Dry run: This issue passed the CQ dry run.

[altimin, 2016-11-22 17:33:16]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 17:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 17:44:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 17:44:38]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Sami, 2016-11-22 18:03:28]

Thanks, this should be useful. lgtm with a tweak.

https://codereview.chromium.org/2517383004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2517383004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1399:
state->SetString(
Could you move this to the policy too?

[altimin, 2016-11-22 19:01:25]

https://codereview.chromium.org/2517383004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2517383004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1399:
state->SetString(
On 2016/11/22 18:03:28, Sami wrote:
> Could you move this to the policy too?

I don't really like this idea. Currently "policy" dictionary precisely matches
RendererSchedulerImpl::Policy. Given that we compare it and do early opt-out
when it is unchanged, I'd like to leave it this way.

[Sami, 2016-11-22 19:10:27]

https://codereview.chromium.org/2517383004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2517383004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1399:
state->SetString(
On 2016/11/22 19:01:24, altimin wrote:
> On 2016/11/22 18:03:28, Sami wrote:
> > Could you move this to the policy too?
> 
> I don't really like this idea. Currently "policy" dictionary precisely matches
> RendererSchedulerImpl::Policy. Given that we compare it and do early opt-out
> when it is unchanged, I'd like to leave it this way.

Ah, right. I wonder if we could come up with a better name to make it clear that
this defines the policy but actually isn't the policy? I don't have good ideas
right now, so let's just leave it as it is.

[altimin, 2016-11-23 01:19:02]

The CQ bit was checked by altimin@chromium.org

[altimin, 2016-11-23 01:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2517383004/#ps40001
(title: "git cl try")

[commit-bot: I haz the power, 2016-11-23 01:19:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 02:57:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479863942593020,
"parent_rev": "9fa735257a4439d8767cdd274f6a937a62082d59", "commit_rev":
"897bd925dd96a19b758d76904ecc276789d976c3"}

[commit-bot: I haz the power, 2016-11-23 02:57:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-23 02:59:58]

Description was changed from

==========
[scheduler] Bunch of improvements for blink scheduler tracing

- Renamed id to task_queue_id due to tracing infrastructure not
  supporting "id" as a field name.
- Added renderer scheduler policy to trace dump.
- Added queue_details to task queue throttler trace dump.

R=skyostil@chromium.org
CC=alexclarke@chromium.org
==========

to

==========
[scheduler] Bunch of improvements for blink scheduler tracing

- Renamed id to task_queue_id due to tracing infrastructure not
  supporting "id" as a field name.
- Added renderer scheduler policy to trace dump.
- Added queue_details to task queue throttler trace dump.

R=skyostil@chromium.org
CC=alexclarke@chromium.org

Committed: https://crrev.com/c3f2e3d02a25ff5094268fe11c6d7357513a0609
Cr-Commit-Position: refs/heads/master@{#434096}
==========

[commit-bot: I haz the power, 2016-11-23 02:59:59]

Patchset 3 (id:??) landed as
https://crrev.com/c3f2e3d02a25ff5094268fe11c6d7357513a0609
Cr-Commit-Position: refs/heads/master@{#434096}