Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp

Issue 2517383002: Use the font height as caret height instead of the line height (Closed)
Patch Set: update comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp b/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
index 608c757175372b1a82f4ae9896ba2f8f453cf97e..24c970925272ecaa9b13af6980b20613677ba003 100644
--- a/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
+++ b/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
@@ -25,7 +25,7 @@ namespace blink {
EXPECT_EQ(text, WebString(selection().selectedText()).utf8())
IntPoint visiblePositionToContentsPoint(const VisiblePosition& pos) {
- IntPoint result = absoluteCaretBoundsOf(pos).minXMaxYCorner();
+ IntPoint result = absoluteSelectionBoundsOf(pos).minXMaxYCorner();
// Need to move the point at least by 1 - caret's minXMaxYCorner is not
// evaluated to the same line as the text by hit testing.
result.move(0, -1);

Powered by Google App Engine
This is Rietveld 408576698