chrome/browser/chrome_browser_main.cc - Issue 2517363002: Decouple Metrics Initialization from IO Thread Initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2517363002: Decouple Metrics Initialization from IO Thread Initialization (Closed)

Patch Set: Add One Level of Indirection Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 9caaf4124250991d1c91b5228c3198feda141e74..d418834126caf5e42a8ca5db409f325f9226017c 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -1223,8 +1223,6 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {

SetupMetrics();

// ChromeOS needs ResourceBundle::InitSharedInstance to be called before this.

- // This also instantiates the IOThread which requests the metrics service and

- // must be after |SetupMetrics()|.

browser_process_->PreCreateThreads();

return content::RESULT_CODE_NORMAL_EXIT;

« no previous file with comments | « no previous file | chrome/browser/io_thread.h » ('j') | chrome/browser/io_thread.cc » ('J')