Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251733007: cleanup: Remove NOTIFICATION_EXTENSION_UNLOADED from managed_user_service.cc (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove NOTIFICATION_EXTENSION_UNLOADED from managed_user_service.cc BUG=354046 R=pam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273179

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -40 lines) Patch
M chrome/browser/managed_mode/managed_user_service.h View 5 chunks +19 lines, -8 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 5 chunks +17 lines, -32 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
limasdf
ptal when you have time
6 years, 6 months ago (2014-05-26 18:19:42 UTC) #1
Pam (message me for reviews)
LGTM - Pam
6 years, 6 months ago (2014-05-27 16:42:29 UTC) #2
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 6 months ago (2014-05-27 16:42:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/251733007/20001
6 years, 6 months ago (2014-05-27 16:43:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-27 19:48:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-27 19:50:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/7999)
6 years, 6 months ago (2014-05-27 19:50:07 UTC) #7
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 6 months ago (2014-05-27 23:34:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/251733007/20001
6 years, 6 months ago (2014-05-27 23:36:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 00:15:04 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 01:52:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157391)
6 years, 6 months ago (2014-05-28 01:52:41 UTC) #12
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 6 months ago (2014-05-28 05:08:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/251733007/20001
6 years, 6 months ago (2014-05-28 05:09:08 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 05:33:51 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 08:37:24 UTC) #16
Message was sent while issue was closed. 
Change committed as 273179

Powered by Google App Engine
This is Rietveld 408576698