Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 251733004: Set kCanMaximizeKey/kCanResizeKey before adding to parent. (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, Mr4D (OOO till 08-26)
Visibility:
Public.

Description

Set kCanMaximizeKey/kCanResizeKey before adding to parent. BUG=None TEST=NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266386 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266671

Patch Set 1 : #

Patch Set 2 : delete delegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -26 lines) Patch
M ui/views/widget/native_widget_aura.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 5 chunks +90 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
oshima
6 years, 8 months ago (2014-04-25 17:20:14 UTC) #1
oshima
6 years, 8 months ago (2014-04-25 17:21:17 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-25 17:28:27 UTC) #3
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-25 17:34:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/251733004/20001
6 years, 8 months ago (2014-04-25 22:13:37 UTC) #5
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 14:02:35 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 14:02:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/251733004/20001
6 years, 8 months ago (2014-04-26 14:03:25 UTC) #8
commit-bot: I haz the power
Change committed as 266386
6 years, 8 months ago (2014-04-26 22:26:10 UTC) #9
tapted
A revert of this CL has been created in https://codereview.chromium.org/257823004/ by tapted@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-28 01:16:55 UTC) #10
oshima
On 2014/04/28 01:16:55, tapted wrote: > A revert of this CL has been created in ...
6 years, 7 months ago (2014-04-28 16:08:32 UTC) #11
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-28 16:08:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/251733004/30001
6 years, 7 months ago (2014-04-28 16:08:48 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 22:23:23 UTC) #14
Message was sent while issue was closed.
Change committed as 266671

Powered by Google App Engine
This is Rietveld 408576698