Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 251733003: Revert of DevTools: matched styles respect :visited/:link pseudo classes (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
apavlov, vsevik, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert of DevTools: matched styles respect :visited/:link pseudo classes (https://codereview.chromium.org/228673002/) Reason for revert: Regressed host rules: crbug.com/363468 Original issue's description: > DevTools: matched styles respect :visited/:link pseudo classes > > Method StyleResolver::pseudoCSSRulesForElement is used from both WebPlatform > (via window.getMatchedCSSRules) and inspector in its styles sidebar pane. > Due to security reasons, this method "lies" about css rules applied for > visited and unvisited links so that it is impossible to sniff user history. > > This patch makes inspector to adjust method results so that it knows which > rules are actually applied and which are not. > > BUG=356999 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171074 TBR=apavlov@chromium.org,vsevik@chromium.org,lushnikov@chromium.org NOTREECHECKS=true NOTRY=true BUG=356999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -217 lines) Patch
M LayoutTests/inspector-protocol/css/css-protocol-test.js View 2 chunks +7 lines, -12 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-visited-link-matched-styles.html View 1 chunk +0 lines, -122 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-visited-link-matched-styles-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 7 chunks +8 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of DevTools: matched styles respect :visited/:link pseudo classes
6 years, 8 months ago (2014-04-25 05:42:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/251733003/1
6 years, 8 months ago (2014-04-25 05:42:43 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 05:43:18 UTC) #3
Message was sent while issue was closed.
Change committed as 172589

Powered by Google App Engine
This is Rietveld 408576698