Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2517303002:
[Sync] Add EnableSyncClientToServerCompression and remove default trial (Closed)
|
Created:
4 years, 1 month ago by Gang Wu Modified:
4 years, 1 month ago Reviewers:
Ilya Sherman CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd entry for EnableSyncClientToServerCompression.
SyncHttpContentCompression is enabled by default now, so remove it.
BUG=667513
Committed: https://crrev.com/f3c8f3de5dab8b70d7fed6cca94eab20a1050c50
Cr-Commit-Position: refs/heads/master@{#433761}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove un-interesting cases #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== add EnableSyncClientToServerCompression and remove default trial BUG=657911 ========== to ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=657911 ==========
gangwu@chromium.org changed reviewers: + isherman@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
Description was changed from ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=657911 ========== to ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=667513 ==========
https://codereview.chromium.org/2517303002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2517303002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:648: } You probably only want to list "Enabled" -- only the first experiment config is tested, and I'm assuming that "Enabled" is the interesting case.
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
"Control" and "Default" removed. https://codereview.chromium.org/2517303002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2517303002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:648: } On 2016/11/21 23:38:38, Ilya Sherman wrote: > You probably only want to list "Enabled" -- only the first experiment config is > tested, and I'm assuming that "Enabled" is the interesting case. Done.
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by gangwu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479779942997970,
"parent_rev": "89108b5d33ba7ce35b66ea47914579ee6a9eebe8", "commit_rev":
"cad54bb7e47f03b78adb3e91be6c8869e56624c6"}
Message was sent while issue was closed.
Description was changed from ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=667513 ========== to ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=667513 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=667513 ========== to ========== Add entry for EnableSyncClientToServerCompression. SyncHttpContentCompression is enabled by default now, so remove it. BUG=667513 Committed: https://crrev.com/f3c8f3de5dab8b70d7fed6cca94eab20a1050c50 Cr-Commit-Position: refs/heads/master@{#433761} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f3c8f3de5dab8b70d7fed6cca94eab20a1050c50 Cr-Commit-Position: refs/heads/master@{#433761} |
