Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2517283002: [Android] Fix generated junit scripts wrt --runtime-deps-file. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix generated junit scripts wrt --runtime-deps-file. The junit tests don't need to worry about pushing runtime deps to the device since they don't run on the device. BUG=667332 Committed: https://crrev.com/221b734a23bc7ae55b2104346dc34124bbe6d296 Cr-Commit-Position: refs/heads/master@{#433631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/android/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbudorick
4 years ago (2016-11-21 18:41:00 UTC) #2
agrieve
lgtm
4 years ago (2016-11-21 19:28:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517283002/1
4 years ago (2016-11-21 19:29:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 20:36:25 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-21 20:41:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/221b734a23bc7ae55b2104346dc34124bbe6d296
Cr-Commit-Position: refs/heads/master@{#433631}

Powered by Google App Engine
This is Rietveld 408576698