Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2517263002: Extract BaseAnalysisDriverTest. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -141 lines) Patch
A pkg/analyzer/test/src/dart/analysis/base.dart View 1 chunk +94 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 18 chunks +15 lines, -86 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/index_test.dart View 5 chunks +3 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-21 18:27:41 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-21 18:37:20 UTC) #2
scheglov
4 years, 1 month ago (2016-11-21 18:59:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
869e52e234b1d5f8a35f46a7a6719b9f51599bbf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698