Drop down list closes on touch scroll/pinch zoom

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 886 matching lines @@
         eventResult =
             mainFrameImpl()->frame()->eventHandler().handleGestureEvent(
                 targetedEvent);
       }
 
       break;
     }
     case WebInputEvent::GestureShowPress:
       m_client->cancelScheduledContentIntents();
     case WebInputEvent::GestureTapDown:
+      // Touch pinch zoom and scroll must hide the popup.

[bokan, 2016/11/21 20:14:36]

Is this comment meant to be a TODO? If so add TODO(sahel): and link to a bug.

[sahel, 2016/11/21 20:41:44]

No, it's not a todo, it's the reason for adding this line of code. In case of a
touch scroll or pinch zoom, this function is called with GestureTapDown rather
than a GSB/GSU/GSE or GPB/GPU/GPE.
I can either get rid of the comment, or explain more, if it's not clear.

[bokan, 2016/11/21 21:09:17]

Where does the translation happen from GesturePinch/GestureScroll ->
GestureTapDown?

[sahel, 2016/11/22 14:31:06]

I believe there isn't any translations. In gesture_detector.cc, on ACTION_DOWN
the OnDown() function is called which generates the GTD. Then, in case of
ACTION_MOVE in gesture_detector.cc/ scale_gesture_detector.cc,
OnScroll()/OnScale() function is called to generate (GSB)GSU/(GPB)GPU.

[bokan, 2016/11/22 16:00:08]

Ah, ok thanks. I didn't know that. (Please add a comment since it's not obvious
that's what happens).

[sahel, 2016/11/24 15:29:25]

Done.

+      hidePopups();
     case WebInputEvent::GestureTapCancel:
     case WebInputEvent::GestureTapUnconfirmed: {
       eventResult = mainFrameImpl()->frame()->eventHandler().handleGestureEvent(
           targetedEvent);
       break;
     }
     default:
       NOTREACHED();
   }
   m_client->didHandleGestureEvent(event, eventCancelled);
@@ skipping 3281 matching lines @@
   if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame())
     return nullptr;
   return focusedFrame;
 }
 
 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const {
   return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink