Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2517243004: Kernel: fix -c dartkp -r dart_precompiled testing configuration. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kernel: fix -c dartkp -r dart_precompiled testing configuration. Pass full snapshot path to the dart_precompiled_runtime executable. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/2cb8640ac1e63bc62edccfe84b6498775b13a142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Vyacheslav Egorov (Google)
PTAL
4 years, 1 month ago (2016-11-22 11:22:13 UTC) #2
kustermann
lgtm
4 years, 1 month ago (2016-11-22 11:48:43 UTC) #3
Vyacheslav Egorov (Google)
4 years ago (2016-11-22 18:35:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cb8640ac1e63bc62edccfe84b6498775b13a142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698