[Sync] Removing complexity around PROXY_TABS now that empty sessions are provided when disabled.

[Sync] Removing complexity around PROXY_TABS now that empty sessions are provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a
Cr-Commit-Position: refs/heads/master@{#436345}

[skym, 2016-11-21 17:56:16]

Description was changed from

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

BUG=665532
==========

to

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[skym, 2016-11-21 18:02:19]

Description was changed from

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[skym, 2016-11-21 18:02:19]

skym@chromium.org changed reviewers:
+ dbeam@chromium.org, jyquinn@google.com

[skym, 2016-11-21 18:02:26]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 18:03:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-11-21 18:32:33]

Description was changed from

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed, sessions data
is always empty when PROXY_TABS aka open tabs is disabled. This makes the
isTabSyncEnabled boolean that is passed through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to differentiate
between having no sessions data and have PROXY_TABS being disabled. However, it
doesn't seem that we currently do this anywhere, and the percentage of the
population that disables PROXY_TABS is so small, it may never make sense to do
this. Worst case we can add this logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-21 19:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:33:38]

Dry run: This issue passed the CQ dry run.

[skym, 2016-11-21 20:05:03]

PTAL.

jyquinn@ for ios file, dbeam@ for everything else.

I'm a little bit surprised at how much churn vulcanize caused. Hopefully I did
that part correctly.

[Dan Beam, 2016-11-21 20:23:36]

note: the ios/ stuff is being removed

https://codereview.chromium.org/2494853003/

[Dan Beam, 2016-11-21 20:25:15]

dbeam@chromium.org changed reviewers:
+ calamity@chromium.org

[Dan Beam, 2016-11-21 20:26:21]

I think calamity@ is more familiar with synced tab on the MD history page.  I
can stamp the other stuff when he's satisfied

/cc tsergeant@ as FYI

[Jackie Quinn, 2016-11-22 17:16:56]

On 2016/11/21 20:26:21, Dan Beam wrote:
> I think calamity@ is more familiar with synced tab on the MD history page.  I
> can stamp the other stuff when he's satisfied
> 
> /cc tsergeant@ as FYI

As dbeam@ says, the ios file will be removed soon, and isn't currently used.
It's fine to not make the change to that file.

[skym, 2016-11-22 17:21:09]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 17:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:19:45]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-11-24 00:29:09]

Mostly lg.

It looks like you have a new version of vulcanize. Can you please install the
exact versions listed in vulcanize.md? We want to keep everyone on the same
version so that output between devs doesn't change too much. This would be
better if node were in the toolchain.

https://codereview.chromium.org/2517243002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (left):

https://codereview.chromium.org/2517243002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:276:
syncedDeviceManagerElem.tabSyncDisabled();
Delete this in synced_device_manager.js

[tsergeant, 2016-11-24 02:29:34]

On 2016/11/24 00:29:09, calamity wrote:
> Mostly lg.
> 
> It looks like you have a new version of vulcanize. Can you please install the
> exact versions listed in vulcanize.md? We want to keep everyone on the same
> version so that output between devs doesn't change too much. This would be
> better if node were in the toolchain.

And you can see the exact `npm install` line you need here:
https://codereview.chromium.org/2525163002/diff/1/docs/vulcanize.md

[skym, 2016-11-29 18:24:02]

Description was changed from

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed, sessions data
is always empty when PROXY_TABS aka open tabs is disabled. This makes the
isTabSyncEnabled boolean that is passed through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to differentiate
between having no sessions data and have PROXY_TABS being disabled. However, it
doesn't seem that we currently do this anywhere, and the percentage of the
population that disables PROXY_TABS is so small, it may never make sense to do
this. Worst case we can add this logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[skym, 2016-11-29 18:25:36]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 18:26:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-11-29 18:30:55]

Vulcanized with correct versions.

https://codereview.chromium.org/2517243002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (left):

https://codereview.chromium.org/2517243002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:276:
syncedDeviceManagerElem.tabSyncDisabled();
On 2016/11/24 00:29:09, calamity wrote:
> Delete this in synced_device_manager.js

Done.

[commit-bot: I haz the power, 2016-11-29 19:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:36:23]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-11-30 03:35:09]

md_history lgtm.

[Dan Beam, 2016-12-02 00:15:28]

lgtm

[skym, 2016-12-02 17:09:08]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:09:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 17:12:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:12:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2016-12-02 22:02:21]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2016-12-02 22:02:42]

Rebase and re-vulcanize after conflict

[commit-bot: I haz the power, 2016-12-02 22:03:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 23:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 23:15:34]

Dry run: This issue passed the CQ dry run.

[skym, 2016-12-05 16:53:05]

The CQ bit was checked by skym@chromium.org

[skym, 2016-12-05 16:53:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2517243002/#ps60001
(title: "Rebase and re-vulcanize after conflict.")

[commit-bot: I haz the power, 2016-12-05 16:53:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 17:56:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480956785191850,
"parent_rev": "7eb9cf5a8e07e73602680522eb7421114ed502e1", "commit_rev":
"c860687e63b48413a5a0808da782ec02e7928f29"}

[commit-bot: I haz the power, 2016-12-05 17:57:01]

Description was changed from

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-05 17:57:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-05 18:00:35]

Description was changed from

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Sync] Removing complexity around PROXY_TABS now that empty sessions are
provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG=665532
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a
Cr-Commit-Position: refs/heads/master@{#436345}
==========

[commit-bot: I haz the power, 2016-12-05 18:00:36]

Patchset 4 (id:??) landed as
https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a
Cr-Commit-Position: refs/heads/master@{#436345}