Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 251723005: Add dubroy, vabr to per-file OWNERS for /components/password_manager* (Closed)

Created:
6 years, 8 months ago by vabr (Chromium)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Mike West
Visibility:
Public.

Description

Add dubroy, vabr to per-file OWNERS for /components/password_manager* It seems that the per-file /components/password_manager* section should match the content of /components/password_manager/OWNERS. The diff is exactly dubroy and vabr (present in the latter, missing in the former). This CL adds them to the former. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vabr (Chromium)
Patrick, Please let me know if this CL makes sense to you. If so, I'll ...
6 years, 8 months ago (2014-04-25 08:47:48 UTC) #1
Patrick Dubroy
On 2014/04/25 08:47:48, vabr (Chromium) wrote: > Patrick, > > Please let me know if ...
6 years, 8 months ago (2014-04-25 22:38:29 UTC) #2
vabr (Chromium)
Hi Colin, Does this look good to you as an OWNER? Cheers, Vaclav
6 years, 8 months ago (2014-04-26 20:00:32 UTC) #3
blundell
LGTM In the CL description, I think you mean "match components/password_manager/OWNERS"
6 years, 7 months ago (2014-04-28 07:42:25 UTC) #4
vabr (Chromium)
On 2014/04/28 07:42:25, blundell wrote: > LGTM Thanks! > > In the CL description, I ...
6 years, 7 months ago (2014-04-28 07:55:58 UTC) #5
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 7 months ago (2014-04-28 07:56:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/251723005/1
6 years, 7 months ago (2014-04-28 07:58:39 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 12:28:27 UTC) #8
Message was sent while issue was closed.
Change committed as 266522

Powered by Google App Engine
This is Rietveld 408576698