Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 251723002: Introduce EmbeddedWorkerDevToolsAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: EmbeddedWorkerDevToolsAgent Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/service_worker/embedded_worker_dispatcher.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/service_worker/embedded_worker_dispatcher.h" 5 #include "content/renderer/service_worker/embedded_worker_dispatcher.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/child/child_process.h" 10 #include "content/child/child_process.h"
11 #include "content/child/scoped_child_process_reference.h" 11 #include "content/child/scoped_child_process_reference.h"
12 #include "content/child/thread_safe_sender.h" 12 #include "content/child/thread_safe_sender.h"
13 #include "content/child/worker_task_runner.h" 13 #include "content/child/worker_task_runner.h"
14 #include "content/common/devtools_messages.h"
14 #include "content/common/service_worker/embedded_worker_messages.h" 15 #include "content/common/service_worker/embedded_worker_messages.h"
15 #include "content/public/common/content_client.h" 16 #include "content/public/common/content_client.h"
16 #include "content/renderer/render_thread_impl.h" 17 #include "content/renderer/render_thread_impl.h"
17 #include "content/renderer/service_worker/embedded_worker_context_client.h" 18 #include "content/renderer/service_worker/embedded_worker_context_client.h"
19 #include "content/renderer/service_worker/embedded_worker_devtools_agent.h"
18 #include "third_party/WebKit/public/platform/WebString.h" 20 #include "third_party/WebKit/public/platform/WebString.h"
19 #include "third_party/WebKit/public/platform/WebURL.h" 21 #include "third_party/WebKit/public/platform/WebURL.h"
20 #include "third_party/WebKit/public/web/WebEmbeddedWorker.h" 22 #include "third_party/WebKit/public/web/WebEmbeddedWorker.h"
21 #include "third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h" 23 #include "third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h"
22 24
23 namespace content { 25 namespace content {
24 26
25 // A thin wrapper of WebEmbeddedWorker which also adds and releases process 27 // A thin wrapper of WebEmbeddedWorker which also adds and releases process
26 // references automatically. 28 // references automatically.
27 class EmbeddedWorkerDispatcher::WorkerWrapper { 29 class EmbeddedWorkerDispatcher::WorkerWrapper {
28 public: 30 public:
29 explicit WorkerWrapper(blink::WebEmbeddedWorker* worker) : worker_(worker) {} 31 explicit WorkerWrapper(blink::WebEmbeddedWorker* worker)
32 : worker_(worker),
33 dev_tools_agent_(new EmbeddedWorkerDevToolsAgent(worker)) {}
30 ~WorkerWrapper() {} 34 ~WorkerWrapper() {}
31 35
32 blink::WebEmbeddedWorker* worker() { return worker_.get(); } 36 blink::WebEmbeddedWorker* worker() { return worker_.get(); }
37 void OnMessageToDevToolsAgent(const IPC::Message& message);
kinuko 2014/04/29 01:16:09 nit: this can just expose dev_tools_agent() field
horo 2014/04/29 06:13:46 Done.
33 38
34 private: 39 private:
35 ScopedChildProcessReference process_ref_; 40 ScopedChildProcessReference process_ref_;
36 scoped_ptr<blink::WebEmbeddedWorker> worker_; 41 scoped_ptr<blink::WebEmbeddedWorker> worker_;
42 scoped_ptr<EmbeddedWorkerDevToolsAgent> dev_tools_agent_;
37 }; 43 };
38 44
45 void EmbeddedWorkerDispatcher::WorkerWrapper::OnMessageToDevToolsAgent(
46 const IPC::Message& message) {
47 dev_tools_agent_->OnMessageReceived(message);
kinuko 2014/04/29 01:16:09 maybe DCHECK the return value (to see if it return
horo 2014/04/29 06:13:46 Done in EmbeddedWorkerDispatcher::OnMessageToDevTo
48 }
49
39 EmbeddedWorkerDispatcher::EmbeddedWorkerDispatcher() : weak_factory_(this) {} 50 EmbeddedWorkerDispatcher::EmbeddedWorkerDispatcher() : weak_factory_(this) {}
40 51
41 EmbeddedWorkerDispatcher::~EmbeddedWorkerDispatcher() {} 52 EmbeddedWorkerDispatcher::~EmbeddedWorkerDispatcher() {}
42 53
43 bool EmbeddedWorkerDispatcher::OnMessageReceived( 54 bool EmbeddedWorkerDispatcher::OnMessageReceived(
44 const IPC::Message& message) { 55 const IPC::Message& message) {
45 bool handled = true; 56 bool handled = true;
46 IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerDispatcher, message) 57 IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerDispatcher, message)
47 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_StartWorker, OnStartWorker) 58 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_StartWorker, OnStartWorker)
48 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_StopWorker, OnStopWorker) 59 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_StopWorker, OnStopWorker)
60 IPC_MESSAGE_HANDLER(EmbeddedWorkerMsg_MessageToDevToolsAgent,
61 OnMessageToDevToolsAgent)
49 IPC_MESSAGE_UNHANDLED(handled = false) 62 IPC_MESSAGE_UNHANDLED(handled = false)
50 IPC_END_MESSAGE_MAP() 63 IPC_END_MESSAGE_MAP()
51 return handled; 64 return handled;
52 } 65 }
53 66
54 void EmbeddedWorkerDispatcher::WorkerContextDestroyed( 67 void EmbeddedWorkerDispatcher::WorkerContextDestroyed(
55 int embedded_worker_id) { 68 int embedded_worker_id) {
56 RenderThreadImpl::current()->thread_safe_sender()->Send( 69 RenderThreadImpl::current()->thread_safe_sender()->Send(
57 new EmbeddedWorkerHostMsg_WorkerStopped(embedded_worker_id)); 70 new EmbeddedWorkerHostMsg_WorkerStopped(embedded_worker_id));
58 workers_.Remove(embedded_worker_id); 71 workers_.Remove(embedded_worker_id);
59 } 72 }
60 73
61 void EmbeddedWorkerDispatcher::OnStartWorker(int embedded_worker_id, 74 void EmbeddedWorkerDispatcher::OnStartWorker(int embedded_worker_id,
62 int64 service_worker_version_id, 75 int64 service_worker_version_id,
63 const GURL& service_worker_scope, 76 const GURL& service_worker_scope,
64 const GURL& script_url) { 77 const GURL& script_url) {
65 DCHECK(!workers_.Lookup(embedded_worker_id)); 78 DCHECK(!workers_.Lookup(embedded_worker_id));
66 scoped_ptr<WorkerWrapper> wrapper(new WorkerWrapper( 79 scoped_ptr<WorkerWrapper> wrapper(
67 blink::WebEmbeddedWorker::create( 80 new WorkerWrapper(blink::WebEmbeddedWorker::create(
68 new EmbeddedWorkerContextClient( 81 new EmbeddedWorkerContextClient(embedded_worker_id,
69 embedded_worker_id, 82 service_worker_version_id,
70 service_worker_version_id, 83 service_worker_scope,
71 service_worker_scope, 84 script_url),
72 script_url),
73 NULL))); 85 NULL)));
74 86
75 blink::WebEmbeddedWorkerStartData start_data; 87 blink::WebEmbeddedWorkerStartData start_data;
76 start_data.scriptURL = script_url; 88 start_data.scriptURL = script_url;
77 start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent()); 89 start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent());
78 start_data.startMode = blink::WebEmbeddedWorkerStartModeDontPauseOnStart; 90 start_data.startMode = blink::WebEmbeddedWorkerStartModeDontPauseOnStart;
79 91
80 wrapper->worker()->startWorkerContext(start_data); 92 wrapper->worker()->startWorkerContext(start_data);
81 workers_.AddWithID(wrapper.release(), embedded_worker_id); 93 workers_.AddWithID(wrapper.release(), embedded_worker_id);
82 } 94 }
83 95
84 void EmbeddedWorkerDispatcher::OnStopWorker(int embedded_worker_id) { 96 void EmbeddedWorkerDispatcher::OnStopWorker(int embedded_worker_id) {
85 WorkerWrapper* wrapper = workers_.Lookup(embedded_worker_id); 97 WorkerWrapper* wrapper = workers_.Lookup(embedded_worker_id);
86 if (!wrapper) { 98 if (!wrapper) {
87 LOG(WARNING) << "Got OnStopWorker for nonexistent worker"; 99 LOG(WARNING) << "Got OnStopWorker for nonexistent worker";
88 return; 100 return;
89 } 101 }
90 102
91 // This should eventually call WorkerContextDestroyed. (We may need to post 103 // This should eventually call WorkerContextDestroyed. (We may need to post
92 // a delayed task to forcibly abort the worker context if we find it 104 // a delayed task to forcibly abort the worker context if we find it
93 // necessary) 105 // necessary)
94 wrapper->worker()->terminateWorkerContext(); 106 wrapper->worker()->terminateWorkerContext();
95 } 107 }
96 108
109 void EmbeddedWorkerDispatcher::OnMessageToDevToolsAgent(
110 int embedded_worker_id,
111 const IPC::Message& message) {
112 WorkerWrapper* wrapper = workers_.Lookup(embedded_worker_id);
113 if (!wrapper) {
114 LOG(WARNING) << "Got OnMessageToDevToolsAgent for nonexistent worker";
115 return;
116 }
117 wrapper->OnMessageToDevToolsAgent(message);
118 }
119
97 } // namespace content 120 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/service_worker/embedded_worker_dispatcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698