Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2517203005: Enable mash_unittests on CrOS Ozone trybot. (Closed)

Created:
4 years ago by kylechar
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable mash_unittests on CrOS Ozone trybot. The mash_unittests target would fail running on the CrOS Ozone trybot. It looks like some broken tests were disabled except if USE_OZONE is defined. Disable the broken tests for Ozone too and run mash_unittests on CrOS Ozone trybot. BUG=658001 Committed: https://crrev.com/0f1facb2dc43a55f613d8a3ad3111f52c53df203 Cr-Commit-Position: refs/heads/master@{#434296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M ash/mus/app_launch_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ash/mus/window_manager_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kylechar
4 years ago (2016-11-23 19:29:12 UTC) #2
kylechar
4 years ago (2016-11-23 19:29:13 UTC) #4
sky
LGTM
4 years ago (2016-11-23 20:49:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517203005/1
4 years ago (2016-11-23 20:50:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 00:28:49 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-24 00:31:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f1facb2dc43a55f613d8a3ad3111f52c53df203
Cr-Commit-Position: refs/heads/master@{#434296}

Powered by Google App Engine
This is Rietveld 408576698