Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2517203003: [interpreter] Fix stack unwinding of deoptimized frames. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Jarin, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix stack unwinding of deoptimized frames. This fixes stack unwinding to always recompute the stack pointer for interpreted frames. For frames materialized by the deoptimizer we elide the handler frame in between, hence arguments being pushed on the stack will no longer be pushed into the handler frame but into the interpreted frame directly. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-662830 BUG=chromium:662830 Committed: https://crrev.com/a90671f1b9674e39dd6ad52de187a97b23525a77 Cr-Commit-Position: refs/heads/master@{#41170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/isolate.cc View 2 chunks +11 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-662830.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-22 10:22:18 UTC) #1
Michael Starzinger
Jaro: PTAL. Ross: FYI.
4 years, 1 month ago (2016-11-22 10:27:35 UTC) #5
Jarin
lgtm, thanks!
4 years, 1 month ago (2016-11-22 10:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517203003/1
4 years, 1 month ago (2016-11-22 11:26:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 11:28:23 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 11:28:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a90671f1b9674e39dd6ad52de187a97b23525a77
Cr-Commit-Position: refs/heads/master@{#41170}

Powered by Google App Engine
This is Rietveld 408576698