Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2517193004: add test, fixes #27807 (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add test, fixes #27807 this appears to have been already working correctly R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/180107cec3ccac0254692f9261ef0ee486ca2b10

Patch Set 1 #

Patch Set 2 : moar tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A pkg/dev_compiler/test/codegen/language/void_subtype_test.dart View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 1 month ago (2016-11-22 00:25:33 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-22 00:36:43 UTC) #3
Jennifer Messerly
4 years, 1 month ago (2016-11-22 00:44:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
180107cec3ccac0254692f9261ef0ee486ca2b10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698