base/metrics/field_trial.cc - Issue 2517193003: Fix adding duplicate trials to allocator (finally)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/field_trial.cc

Issue 2517193003: Fix adding duplicate trials to allocator (finally) (Closed)

Patch Set: address nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/field_trial.cc

diff --git a/base/metrics/field_trial.cc b/base/metrics/field_trial.cc

index 970441160ca4afe2acb501095c8e81716e3c45ce..03f51a188ebe4a0894cfe30e79d22f3519f15ba1 100644

--- a/base/metrics/field_trial.cc

+++ b/base/metrics/field_trial.cc

@@ -362,7 +362,7 @@ void FieldTrial::FinalizeGroupChoiceImpl(bool is_locked) {

SetGroupChoice(default_group_name_, kDefaultGroupNumber);

// Add the field trial to shared memory.

- if (kUseSharedMemoryForFieldTrials)

+ if (kUseSharedMemoryForFieldTrials && trial_registered_)

FieldTrialList::OnGroupFinalized(is_locked, this);

}

« no previous file with comments | « base/metrics/field_trial.h ('k') | base/metrics/field_trial_unittest.cc » ('j') | no next file with comments »