Reland of Minor style changes to HarfBuzzShaper to improve readability

third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

 /*
  * Copyright (c) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 BlackBerry Limited. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 314 matching lines @@
     Deque<HolesQueueItem>* queue,
     HolesQueueItem& currentQueueItem,
     SmallCapsIterator::SmallCapsBehavior& smallCapsBehavior) {
   unsigned numCharactersUntilCaseChange = 0;
   SmallCapsIterator smallCapsIterator(
       normalizedBuffer + currentQueueItem.m_startIndex,
       currentQueueItem.m_numCharacters);
   smallCapsIterator.consume(&numCharactersUntilCaseChange, &smallCapsBehavior);
   if (numCharactersUntilCaseChange > 0 &&
       numCharactersUntilCaseChange < currentQueueItem.m_numCharacters) {
-    unsigned startIndex =
-        currentQueueItem.m_startIndex + numCharactersUntilCaseChange;
-    unsigned numCharacters =
-        currentQueueItem.m_numCharacters - numCharactersUntilCaseChange;
-    queue->prepend(HolesQueueItem(HolesQueueItemAction::HolesQueueRange,
-                                  startIndex, numCharacters));
+    queue->prepend(HolesQueueItem(
+        HolesQueueItemAction::HolesQueueRange,
+        currentQueueItem.m_startIndex + numCharactersUntilCaseChange,
+        currentQueueItem.m_numCharacters - numCharactersUntilCaseChange));
     currentQueueItem.m_numCharacters = numCharactersUntilCaseChange;
   }
 }
 
-hb_feature_t createFeature(uint8_t c1,
-                           uint8_t c2,
-                           uint8_t c3,
-                           uint8_t c4,
-                           uint32_t value = 0) {
-  return {HB_TAG(c1, c2, c3, c4), value, 0 /* start */,
-          static_cast<unsigned>(-1) /* end */};
+hb_feature_t createFeature(hb_tag_t tag, uint32_t value = 0) {
+  return {tag, value, 0 /* start */, static_cast<unsigned>(-1) /* end */};
 }
 
 void setFontFeatures(const Font* font, FeaturesVector* features) {
   const FontDescription& description = font->getFontDescription();
 
-  static hb_feature_t noKern = createFeature('k', 'e', 'r', 'n');
-  static hb_feature_t noVkrn = createFeature('v', 'k', 'r', 'n');
+  static hb_feature_t noKern = createFeature(HB_TAG('k', 'e', 'r', 'n'));
+  static hb_feature_t noVkrn = createFeature(HB_TAG('v', 'k', 'r', 'n'));
   switch (description.getKerning()) {
     case FontDescription::NormalKerning:
       // kern/vkrn are enabled by default
       break;
     case FontDescription::NoneKerning:
       features->append(description.isVerticalAnyUpright() ? noVkrn : noKern);
       break;
     case FontDescription::AutoKerning:
       break;
   }
 
-  static hb_feature_t noClig = createFeature('c', 'l', 'i', 'g');
-  static hb_feature_t noLiga = createFeature('l', 'i', 'g', 'a');
+  static hb_feature_t noClig = createFeature(HB_TAG('c', 'l', 'i', 'g'));
+  static hb_feature_t noLiga = createFeature(HB_TAG('l', 'i', 'g', 'a'));
   switch (description.commonLigaturesState()) {
     case FontDescription::DisabledLigaturesState:
       features->append(noLiga);
       features->append(noClig);
       break;
     case FontDescription::EnabledLigaturesState:
       // liga and clig are on by default
       break;
     case FontDescription::NormalLigaturesState:
       break;
   }
-  static hb_feature_t dlig = createFeature('d', 'l', 'i', 'g', 1);
+  static hb_feature_t dlig = createFeature(HB_TAG('d', 'l', 'i', 'g'), 1);
   switch (description.discretionaryLigaturesState()) {
     case FontDescription::DisabledLigaturesState:
       // dlig is off by default
       break;
     case FontDescription::EnabledLigaturesState:
       features->append(dlig);
       break;
     case FontDescription::NormalLigaturesState:
       break;
   }
-  static hb_feature_t hlig = createFeature('h', 'l', 'i', 'g', 1);
+  static hb_feature_t hlig = createFeature(HB_TAG('h', 'l', 'i', 'g'), 1);
   switch (description.historicalLigaturesState()) {
     case FontDescription::DisabledLigaturesState:
       // hlig is off by default
       break;
     case FontDescription::EnabledLigaturesState:
       features->append(hlig);
       break;
     case FontDescription::NormalLigaturesState:
       break;
   }
-  static hb_feature_t noCalt = createFeature('c', 'a', 'l', 't');
+  static hb_feature_t noCalt = createFeature(HB_TAG('c', 'a', 'l', 't'));
   switch (description.contextualLigaturesState()) {
     case FontDescription::DisabledLigaturesState:
       features->append(noCalt);
       break;
     case FontDescription::EnabledLigaturesState:
       // calt is on by default
       break;
     case FontDescription::NormalLigaturesState:
       break;
   }
 
-  static hb_feature_t hwid = createFeature('h', 'w', 'i', 'd', 1);
-  static hb_feature_t twid = createFeature('t', 'w', 'i', 'd', 1);
-  static hb_feature_t qwid = createFeature('q', 'w', 'i', 'd', 1);
+  static hb_feature_t hwid = createFeature(HB_TAG('h', 'w', 'i', 'd'), 1);
+  static hb_feature_t twid = createFeature(HB_TAG('t', 'w', 'i', 'd'), 1);
+  static hb_feature_t qwid = createFeature(HB_TAG('q', 'w', 'i', 'd'), 1);
   switch (description.widthVariant()) {
     case HalfWidth:
       features->append(hwid);
       break;
     case ThirdWidth:
       features->append(twid);
       break;
     case QuarterWidth:
       features->append(qwid);
       break;
     case RegularWidth:
       break;
   }
 
   // font-variant-numeric:
-  static hb_feature_t lnum = createFeature('l', 'n', 'u', 'm', 1);
+  static hb_feature_t lnum = createFeature(HB_TAG('l', 'n', 'u', 'm'), 1);
   if (description.variantNumeric().numericFigureValue() ==
       FontVariantNumeric::LiningNums)
     features->append(lnum);
 
-  static hb_feature_t onum = createFeature('o', 'n', 'u', 'm', 1);
+  static hb_feature_t onum = createFeature(HB_TAG('o', 'n', 'u', 'm'), 1);
   if (description.variantNumeric().numericFigureValue() ==
       FontVariantNumeric::OldstyleNums)
     features->append(onum);
 
-  static hb_feature_t pnum = createFeature('p', 'n', 'u', 'm', 1);
+  static hb_feature_t pnum = createFeature(HB_TAG('p', 'n', 'u', 'm'), 1);
   if (description.variantNumeric().numericSpacingValue() ==
       FontVariantNumeric::ProportionalNums)
     features->append(pnum);
-  static hb_feature_t tnum = createFeature('t', 'n', 'u', 'm', 1);
+  static hb_feature_t tnum = createFeature(HB_TAG('t', 'n', 'u', 'm'), 1);
   if (description.variantNumeric().numericSpacingValue() ==
       FontVariantNumeric::TabularNums)
     features->append(tnum);
 
-  static hb_feature_t afrc = createFeature('a', 'f', 'r', 'c', 1);
+  static hb_feature_t afrc = createFeature(HB_TAG('a', 'f', 'r', 'c'), 1);
   if (description.variantNumeric().numericFractionValue() ==
       FontVariantNumeric::StackedFractions)
     features->append(afrc);
-  static hb_feature_t frac = createFeature('f', 'r', 'a', 'c', 1);
+  static hb_feature_t frac = createFeature(HB_TAG('f', 'r', 'a', 'c'), 1);
   if (description.variantNumeric().numericFractionValue() ==
       FontVariantNumeric::DiagonalFractions)
     features->append(frac);
 
-  static hb_feature_t ordn = createFeature('o', 'r', 'd', 'n', 1);
+  static hb_feature_t ordn = createFeature(HB_TAG('o', 'r', 'd', 'n'), 1);
   if (description.variantNumeric().ordinalValue() ==
       FontVariantNumeric::OrdinalOn)
     features->append(ordn);
 
-  static hb_feature_t zero = createFeature('z', 'e', 'r', 'o', 1);
+  static hb_feature_t zero = createFeature(HB_TAG('z', 'e', 'r', 'o'), 1);
   if (description.variantNumeric().slashedZeroValue() ==
       FontVariantNumeric::SlashedZeroOn)
     features->append(zero);
 
   FontFeatureSettings* settings = description.featureSettings();
   if (!settings)
     return;
 
   // TODO(drott): crbug.com/450619 Implement feature resolution instead of
   // just appending the font-feature-settings.
@@ skipping 27 matching lines @@
 
 CapsFeatureSettingsScopedOverlay::CapsFeatureSettingsScopedOverlay(
     FeaturesVector* features,
     FontDescription::FontVariantCaps variantCaps)
     : m_features(features), m_countFeatures(0) {
   overlayCapsFeatures(variantCaps);
 }
 
 void CapsFeatureSettingsScopedOverlay::overlayCapsFeatures(
     FontDescription::FontVariantCaps variantCaps) {
-  static hb_feature_t smcp = createFeature('s', 'm', 'c', 'p', 1);
-  static hb_feature_t pcap = createFeature('p', 'c', 'a', 'p', 1);
-  static hb_feature_t c2sc = createFeature('c', '2', 's', 'c', 1);
-  static hb_feature_t c2pc = createFeature('c', '2', 'p', 'c', 1);
-  static hb_feature_t unic = createFeature('u', 'n', 'i', 'c', 1);
-  static hb_feature_t titl = createFeature('t', 'i', 't', 'l', 1);
+  static hb_feature_t smcp = createFeature(HB_TAG('s', 'm', 'c', 'p'), 1);
+  static hb_feature_t pcap = createFeature(HB_TAG('p', 'c', 'a', 'p'), 1);
+  static hb_feature_t c2sc = createFeature(HB_TAG('c', '2', 's', 'c'), 1);
+  static hb_feature_t c2pc = createFeature(HB_TAG('c', '2', 'p', 'c'), 1);
+  static hb_feature_t unic = createFeature(HB_TAG('u', 'n', 'i', 'c'), 1);
+  static hb_feature_t titl = createFeature(HB_TAG('t', 'i', 't', 'l'), 1);
   if (variantCaps == FontDescription::SmallCaps ||
       variantCaps == FontDescription::AllSmallCaps) {
     prependCounting(smcp);
     if (variantCaps == FontDescription::AllSmallCaps) {
       prependCounting(c2sc);
     }
   }
   if (variantCaps == FontDescription::PetiteCaps ||
       variantCaps == FontDescription::AllPetiteCaps) {
     prependCounting(pcap);
@@ skipping 143 matching lines @@
               segmentRange.script, !fallbackIterator->hasNext()))
         DLOG(ERROR) << "Shape result extraction failed.";
 
       hb_buffer_reset(harfBuzzBuffer.get());
     }
   }
   return result.release();
 }
 
 }  // namespace blink