Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2517183002: Add a configurable maximum parse depth for the blink JSON parser. (Closed)

Created:
4 years, 1 month ago by iclelland
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a configurable maximum parse depth for the blink JSON parser. BUG=662920 Committed: https://crrev.com/928cd03454e06bf9833e1940aa58d014acafcf99 Cr-Commit-Position: refs/heads/master@{#433716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/json/JSONParser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/json/JSONParser.cpp View 6 chunks +19 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/json/JSONParserTest.cpp View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
iclelland
+r pfeldman, can you PTAL? If this looks okay, I'll update the fuzzers to use ...
4 years, 1 month ago (2016-11-21 16:52:22 UTC) #6
pfeldman
lgtm
4 years, 1 month ago (2016-11-21 22:40:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517183002/1
4 years, 1 month ago (2016-11-22 00:40:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 00:51:00 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 00:57:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/928cd03454e06bf9833e1940aa58d014acafcf99
Cr-Commit-Position: refs/heads/master@{#433716}

Powered by Google App Engine
This is Rietveld 408576698