Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2517173003: [wasm] Do not create special wrappers for i64 imports on 32-bit platforms (Closed)

Created:
4 years ago by ahaas
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Do not create special wrappers for i64 imports on 32-bit platforms Wrapper creation for import functions with i64 return values on 32-bit platforms crashed because the number of return values of the wrapper did not match the number of input nodes of the return node. The issue is fixed by not creating special wrappers for 32-bit platforms in the first place. This is valid because wrappers with i64 return values are never actually executed. R=titzer@chromium.org BUG=v8:5661 Committed: https://crrev.com/339b0a093c8083a3b53c686637e984dd916e87de Cr-Commit-Position: refs/heads/master@{#41190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ahaas
4 years ago (2016-11-22 14:35:45 UTC) #1
titzer
On 2016/11/22 14:35:45, ahaas wrote: lgtm
4 years ago (2016-11-22 14:41:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517173003/1
4 years ago (2016-11-22 16:42:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 16:44:32 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-22 16:44:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/339b0a093c8083a3b53c686637e984dd916e87de
Cr-Commit-Position: refs/heads/master@{#41190}

Powered by Google App Engine
This is Rietveld 408576698