Use more unique_ptrs in CPDF_Image.

Use more unique_ptrs in CPDF_Image.

Do the same in CPDF_TextObject.
Discover CPDF_PageObject::Clone() is unnecessary and remove it.

Committed: https://pdfium.googlesource.com/pdfium/+/6a1c9bd09ef8fdd2fe2f9e39b9a05f6581be9d87

[Lei Zhang, 2016-11-21 23:31:04]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 23:31:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-21 23:31:59]

Description was changed from

==========
Use more unique_ptrs in CPDF_Image.
==========

to

==========
Use more unique_ptrs in CPDF_Image.

Do the same in CPDF_TextObject.
Discover CPDF_PageObject::Clone() is unnecessary and remove it.
==========

[Lei Zhang, 2016-11-21 23:31:59]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-11-21 23:36:04]

On 2016/11/21 23:31:59, Lei Zhang (Mostly OOO) wrote:
> mailto:thestig@chromium.org changed reviewers:
> + mailto:tsepez@chromium.org

You'll need to rebase past https://codereview.chromium.org/2520133002/ (in CQ
now).

[Tom Sepez, 2016-11-21 23:38:22]

Looks good, let me know following rebase.

https://codereview.chromium.org/2517163003/diff/40001/core/fpdfapi/page/cpdf_...
File core/fpdfapi/page/cpdf_textobject.cpp (right):

https://codereview.chromium.org/2517163003/diff/40001/core/fpdfapi/page/cpdf_...
core/fpdfapi/page/cpdf_textobject.cpp:116: 
nit: no blank line needed here?

[commit-bot: I haz the power, 2016-11-21 23:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:56:19]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-22 00:00:22]

I'll wait a bit.

https://codereview.chromium.org/2517163003/diff/1/core/fpdfapi/page/cpdf_imag...
File core/fpdfapi/page/cpdf_imageobject.cpp (right):

https://codereview.chromium.org/2517163003/diff/1/core/fpdfapi/page/cpdf_imag...
core/fpdfapi/page/cpdf_imageobject.cpp:28: obj->m_pImageOwned = true;
This seems like the correct thing to do. I have no idea why we haven't detected
a memory leak here... then I realized this is all dead code.

https://codereview.chromium.org/2517163003/diff/40001/core/fpdfapi/page/cpdf_...
File core/fpdfapi/page/cpdf_textobject.cpp (right):

https://codereview.chromium.org/2517163003/diff/40001/core/fpdfapi/page/cpdf_...
core/fpdfapi/page/cpdf_textobject.cpp:116: 
On 2016/11/21 23:38:22, Tom Sepez wrote:
> nit: no blank line needed here?

All the CPDF_PageObject subclasses have this. It separates the  CPDF_PageObject
variable cloning vs the subclass-specific bits.

[Tom Sepez, 2016-11-22 00:23:27]

Landed.  Go for rebase.

[Lei Zhang, 2016-11-22 00:30:09]

PTAL

[Tom Sepez, 2016-11-22 00:37:38]

lgtm

[Lei Zhang, 2016-11-22 00:40:42]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:40:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 00:52:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479775242489180,
"parent_rev": "06104a8abc71ecd824d6a461b6f6f31c32fd2135", "commit_rev":
"6a1c9bd09ef8fdd2fe2f9e39b9a05f6581be9d87"}

[commit-bot: I haz the power, 2016-11-22 00:52:45]

Description was changed from

==========
Use more unique_ptrs in CPDF_Image.

Do the same in CPDF_TextObject.
Discover CPDF_PageObject::Clone() is unnecessary and remove it.
==========

to

==========
Use more unique_ptrs in CPDF_Image.

Do the same in CPDF_TextObject.
Discover CPDF_PageObject::Clone() is unnecessary and remove it.

Committed:
https://pdfium.googlesource.com/pdfium/+/6a1c9bd09ef8fdd2fe2f9e39b9a05f6581be...
==========

[commit-bot: I haz the power, 2016-11-22 00:52:46]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6a1c9bd09ef8fdd2fe2f9e39b9a05f6581be...