Introduce set_the_hole(Isolate*, int) and friends

Introduce set_the_hole(Isolate*, int) and friends

Passing in the isolate to retrieve the heap constants (undefine, the_hole, null)
has a positive performance impact.

BUG=

Committed: https://crrev.com/bbb74424ae97dee64fdbf4761688a0b4571b9c8d
Cr-Commit-Position: refs/heads/master@{#41210}

[Camillo Bruni, 2016-11-21 13:56:12]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 13:56:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 14:28:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 14:28:52]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-11-22 15:23:34]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-11-22 15:23:35]

PTAL

[Jakob Kummerow, 2016-11-22 15:34:04]

lgtm

[Camillo Bruni, 2016-11-22 15:50:26]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 16:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 16:27:37]

Failed to apply patch for src/elements.cc:
While running git apply --index -p1;
  error: patch failed: src/elements.cc:762
  error: src/elements.cc: patch does not apply

Patch:       src/elements.cc
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index
ccbdb40706262a611fa4d618ad14b1cccf611bdc..bd919664a54ecd262991a7ee5c5d90fd5995af3c
100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -185,14 +185,15 @@ static void CopyDictionaryToObjectElements(
   WriteBarrierMode write_barrier_mode = IsFastObjectElementsKind(to_kind)
                                             ? UPDATE_WRITE_BARRIER
                                             : SKIP_WRITE_BARRIER;
+  Isolate* isolate = from->GetIsolate();
   for (int i = 0; i < copy_size; i++) {
     int entry = from->FindEntry(i + from_start);
     if (entry != SeededNumberDictionary::kNotFound) {
       Object* value = from->ValueAt(entry);
-      DCHECK(!value->IsTheHole(from->GetIsolate()));
+      DCHECK(!value->IsTheHole(isolate));
       to->set(i + to_start, value, write_barrier_mode);
     } else {
-      to->set_the_hole(i + to_start);
+      to->set_the_hole(isolate, i + to_start);
     }
   }
 }
@@ -762,9 +763,7 @@ class ElementsAccessorBase : public ElementsAccessor {
             *backing_store, capacity - length);
       } else {
         // Otherwise, fill the unused tail with holes.
-        for (uint32_t i = length; i < old_length; i++) {
-          BackingStore::cast(*backing_store)->set_the_hole(i);
-        }
+        BackingStore::cast(*backing_store)->FillWithHoles(length, old_length);
       }
     } else {
       // Check whether the backing store should be expanded.
@@ -1816,7 +1815,7 @@ class FastElementsAccessor : public
ElementsAccessorBase<Subclass, KindTraits> {
     }
 
     Isolate* isolate = obj->GetIsolate();
-    backing_store->set_the_hole(entry);
+    backing_store->set_the_hole(isolate, entry);
 
     // TODO(verwaest): Move this out of elements.cc.
     // If an old space backing store is larger than a certain size and
@@ -3283,7 +3282,7 @@ class SlowSloppyArgumentsElementsAccessor
       context->set(context_entry, *value);
 
       // Redefining attributes of an aliased element destroys fast aliasing.
-      parameter_map->set_the_hole(entry + 2);
+      parameter_map->set_the_hole(isolate, entry + 2);
       // For elements that are still writable we re-establish slow aliasing.
       if ((attributes & READ_ONLY) == 0) {
         value = isolate->factory()->NewAliasedArgumentsEntry(context_entry);
@@ -3342,7 +3341,7 @@ class FastSloppyArgumentsElementsAccessor
       if (entry != kMaxUInt32 && HasEntryImpl(isolate, parameters, entry)) {
         elements->set(insertion_index, *GetImpl(parameters, entry));
       } else {
-        elements->set_the_hole(insertion_index);
+        elements->set_the_hole(isolate, insertion_index);
       }
       insertion_index++;
     }

[Camillo Bruni, 2016-11-23 09:15:14]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-11-23 09:15:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2517153002/#ps20001
(title: "merged with master")

[commit-bot: I haz the power, 2016-11-23 09:15:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 09:43:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479892514522720,
"parent_rev": "9f79c54b1e54194d6543b7d4aa6970203b0ecdbd", "commit_rev":
"fd0f3add0ec626c9872be1d4348e47a3400aef16"}

[commit-bot: I haz the power, 2016-11-23 09:43:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 09:44:13]

Description was changed from

==========
Introduce set_the_hole(Isolate*, int) and friends

Passing in the isolate to retrieve the heap constants (undefine, the_hole, null)
has a positive performance impact.

BUG=
==========

to

==========
Introduce set_the_hole(Isolate*, int) and friends

Passing in the isolate to retrieve the heap constants (undefine, the_hole, null)
has a positive performance impact.

BUG=

Committed: https://crrev.com/bbb74424ae97dee64fdbf4761688a0b4571b9c8d
Cr-Commit-Position: refs/heads/master@{#41210}
==========

[commit-bot: I haz the power, 2016-11-23 09:44:14]

Patchset 2 (id:??) landed as
https://crrev.com/bbb74424ae97dee64fdbf4761688a0b4571b9c8d
Cr-Commit-Position: refs/heads/master@{#41210}